Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10653 closed enhancement (fixed)

Add missing shop types

Reported by: Math1985 Owned by: team
Priority: normal Milestone: 14.11
Component: Internal preset Version:
Keywords: Cc: Klumbumbus

Description (last modified by Klumbumbus)

There are a couple of popular shop types (more than 1000 instances) that are missing from JOSM. These include:

  • funeral_directors done
  • art done
  • charity
  • farm done (preset was already there, only mappaint style missong)
  • music done
  • photo
  • tattoo done
  • wine done

Icons (under CC-0 license) can be found here: http://osm-icons.org/wiki/Icons The icons there are monochrome, so recoloring them to purple would probably look best.

Would it be possible to add these icons?

Attachments (1)

16px.png (1.1 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 Changed 5 years ago by Don-vip

Milestone: 14.11

Not this week are we're in stabilization.

comment:2 Changed 5 years ago by Math1985

Sure, take your time :).

comment:3 Changed 5 years ago by mkoniecz

shop=charity has a big problem - it is orthogonal to all other shop types. It may work in limited situations (USA?). But how one should tag shop operated by a charity, for the purposes of fundraising selling clothes?

This tagging scheme should not be promoted.

(note: I was not checking other proposed additions)

Last edited 5 years ago by mkoniecz (previous) (diff)

comment:4 Changed 5 years ago by anonymous

Charity shops are a well-defined shop-type in the UK. They are very popular, even a small town centre (100.000 inhabitans) usually has 5 to 10 charity shops. They normally sell, almost by definition, second hand products. Clothes and books are usually large components of the range of goods, but they might sell anything really (toys, electronics, decorations, etc) within one shop. See Google images: https://www.google.co.uk/search?q=charity+shop&safe=off&client=firefox-a&hs=nWz&rls=org.mozilla:en-US:official&channel=sb&source=lnms&tbm=isch&sa=X&ei=NF5FVMr-OtSBygT7nIHoCA&ved=0CAkQ_AUoAg

Such shops basically don't exist outside the UK. In Poland there are a handful of them under the Sue Ryder brand: http://sueryder.pl/en/sue-ryder-shop/

comment:5 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:6 in reply to:  4 ; Changed 5 years ago by skyper

Replying to anonymous:

Charity shops are a well-defined shop-type in the UK. They are very popular, even a small town centre (100.000 inhabitans) usually has 5 to 10 charity shops. They normally sell, almost by definition, second hand products. Clothes and books are usually large components of the range of goods, but they might sell anything really (toys, electronics, decorations, etc) within one shop. See Google images: https://www.google.co.uk/search?q=charity+shop&safe=off&client=firefox-a&hs=nWz&rls=org.mozilla:en-US:official&channel=sb&source=lnms&tbm=isch&sa=X&ei=NF5FVMr-OtSBygT7nIHoCA&ved=0CAkQ_AUoAg

Such shops basically don't exist outside the UK. In Poland there are a handful of them under the Sue Ryder brand: http://sueryder.pl/en/sue-ryder-shop/

So, please, tell me the difference between a shop=book;clothes, second_hand=only, operator=* and a shop=charity. Sounds like some chain of second-hand shops to me.

The bigger problem is to have/find a tag for shops which offers such wide variety of products, no matter if they sell first hand, outlet or second hand products and no matter who is the operator.

comment:7 Changed 5 years ago by mkoniecz

shop=art also has problems - name is rather poor - I have seen it used many times for shops with art supplies.

shop=tattoo for tattoo parlour seems weird.

Last edited 5 years ago by mkoniecz (previous) (diff)

comment:8 Changed 5 years ago by Klumbumbus

music icon [o30786]

comment:9 Changed 5 years ago by Klumbumbus

In 7685/josm:

see #10653 - add shop=music to preset and mappaint style

comment:10 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:11 Changed 5 years ago by Klumbumbus

funeral_directors and wine icon [o30787]

comment:12 Changed 5 years ago by Klumbumbus

In 7686/josm:

see #10653 - add shop=funeral_director and shop=wine to preset and mappaint style

comment:13 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:14 Changed 5 years ago by Klumbumbus

art and tattoo icons [o30790]

comment:15 Changed 5 years ago by Klumbumbus

In 7705/josm:

see #10653 - add shop=art, shop=tattoo and shop=farm to preset and mappaint style (farm preset already availible)

comment:16 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:17 Changed 5 years ago by Math1985

Great, thank you for the changes so far! I see you haven't used the icons I pointed to, are there any standards or preferences for what kind of icons to use?

Changed 5 years ago by Klumbumbus

Attachment: 16px.png added

comment:18 Changed 5 years ago by Klumbumbus

See DevelopersGuide/DefaultPresets. The icons from osm-icons.org mostly are not identifiable at a size of 16px. This is becasue they waste a lot space around the actual icon and have often to small important details. However I used some of these icons and modified them to work with 16px. (see funeral_directors)


comment:19 Changed 5 years ago by Don-vip

can we close this subject this week?

comment:20 in reply to:  6 ; Changed 5 years ago by Klumbumbus

Replying to skyper:

Sounds like some chain of second-hand shops to me.

No. Charity shops are different from second_hand shops. In charity shops people give the goods they don't need anymore for free. Socially disadvantaged people can by these things there for low price. Mostly also unemployed people work there which makes this also a bit of a social facility (more details see wikipedia). In germany they are often called "Sozialkaufhaus"google images.

comment:21 in reply to:  20 Changed 5 years ago by skyper

Replying to Klumbumbus:

Replying to skyper:

Sounds like some chain of second-hand shops to me.

No. Charity shops are different from second_hand shops. In charity shops people give the goods they don't need anymore for free. Socially disadvantaged people can by these things there for low price. Mostly also unemployed people work there which makes this also a bit of a social facility (more details see wikipedia). In germany they are often called "Sozialkaufhaus"google images.

I know all kinds of them.
Though I still think you better treat them with subtags and the proper shop=* + second_hand=only. In most of the shops, I know, you can by as ordinary person as well (sometimes for a higher price) and the fact of employing people which are so call "difficult to employ" better fits under social_facility and is by far true for only these shops but also for other amenity=* and office=*.

comment:22 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

Enough talk for this release. Please create a new ticket, if applicable, for the potential missing values.

comment:23 Changed 5 years ago by Math1985

Great work, thanks a lot!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.