Modify

Opened 9 years ago

Closed 9 years ago

#10602 closed defect (othersoftware)

Download without Data

Reported by: rayquaza Owned by: Gnonthgol
Priority: normal Milestone:
Component: Plugin continuosDownload Version: tested
Keywords: github Cc:

Description

I guess this change breaks my use-case: https://github.com/Gnonthgol/JOSM-continuos-download/commit/30d38fedc28b74b9d78528cac8be7b523f8fa116

I'm using continuosDownload because I want to start with Mapnik in a region-size view, zoom to where I want to edit and only load a tiny area by activating continuosDownload only shortly. Therefore it would be great to have the old behaviour without this check.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-09-29 22:12:08
Last Changed Author: Don-vip
Revision: 7588
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-09-29 23:52:43 +0200 (Mon, 29 Sep 2014)
Last Changed Rev: 7588

Identification: JOSM/1.5 (7588 de) Windows XP 32-Bit
Memory Usage: 215 MB / 742 MB (120 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM

Plugins:
- CommandLine (30678)
- Create_grid_of_ways (30416)
- FastDraw (30416)
- InfoMode (30416)
- OpeningHoursEditor (30609)
- PicLayer (30436)
- SimplifyArea (30624)
- alignways (30631)
- buildings_tools (30485)
- conflation (0.1.7)
- continuosDownload (1412331234)
- contourmerge (1010)
- dataimport (30416)
- download_along (30416)
- geochat (30513)
- graphview (30416)
- imageryadjust (30416)
- importvec (30416)
- jts (30416)
- measurement (30641)
- merge-overlap (30416)
- mirrored_download (30664)
- namemanager (30416)
- notes (v0.9.4)
- osmarender (30416)
- pbf (30690)
- poly (30495)
- print (30416)
- proj4j (30483)
- reltoolbox (30587)
- reverter (30521)
- scripting (30700)
- surveyor2 (28656)
- tag2link (30416)
- tagging-preset-tester (30592)
- terracer (30643)
- todo (29154)
- turnrestrictions (30651)
- undelete (30416)
- utilsplugin2 (30460)

Last errors/warnings:
- E: Defekte Objektvorlage "frequency-Frequency" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein
- E: Defekte Objektvorlage "frequency-Frequency" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein
- E: Defekte Objektvorlage "frequency-Frequency" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein
- E: Defekte Objektvorlage "frequency-Frequency" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein
- E: Defekte Objektvorlage "railway:signal:speed_limit:speed-Speed (km/h, in case of light signals separate the possible values (number or 'off') with ';')" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein

Attachments (0)

Change History (6)

comment:1 by Gnonthgol, 9 years ago

The downloaded data does not have to be in view. I recommend that the first time you zoom to an area you click the normal "Download data" button and then just "OK" which will download the data in your current view. ContinuousDownload will then continue to download data as you zoom and pan around.

comment:2 by rayquaza, 9 years ago

But this resets the location at which JOSM starts. Besides that it unneccessaryly takes longer (Pressing a button twice versus searching "Download data").

comment:3 by rayquaza, 9 years ago

Untested Patch, assuming there's no other reason behind the change than usability for other users:
Change Line 30 to

if (existing.size() == 0 && Main.pref.getBoolean("plugin.continuos_download.check_datalayer", true))

comment:4 by Don-vip, 9 years ago

Can you please discuss this on Github? Thanks.

comment:5 by rayquaza, 9 years ago

I don't have a Github account and don't want one.

in reply to:  5 comment:6 by Don-vip, 9 years ago

Keywords: github added
Resolution: othersoftware
Status: newclosed

Replying to rayquaza:

I don't have a Github account and don't want one.

Well I don't want our Trac instance overwhelmed with changes that should be discussed on Github, so I'm closing this one as well.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Gnonthgol.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.