Modify

Opened 5 years ago

Closed 5 years ago

#10513 closed defect (fixed)

Error in validator for opening_hours (Cannot modify a property of a sealed object)

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 14.09
Component: Core validator Version:
Keywords: template_report java7 webstart Cc:

Description

What steps will reproduce the problem?

  1. add opening_hours=Mo-Su 09:00-21:00
  2. validate

What is the expected result?

no error, since the value should be fine

What happens instead?

validator gives the following error:

opening_hours - InternalError: Cannot modify a property of a sealed object: getWeekNumber. (<Unknown source>#4244)

Please provide any additional information below. Attach a screenshot if
possible.

Happens with latest and testst. I can attach debug console output if needed.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-09-14 01:33:36
Last Changed Author: Don-vip
Revision: 7533
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-09-14 02:28:06 +0200 (Sun, 14 Sep 2014)
Last Changed Rev: 7533

Identification: JOSM/1.5 (7533 en) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (166 MB allocated, but free)
Java version: 1.7.0_67, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=62655, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30416)
- HouseNumberTaggingTool (30416)
- OpeningHoursEditor (30609)
- PicLayer (30436)
- Tracer2 (30416)
- buildings_tools (30485)
- editgpx (30416)
- imagery_offset_db (30534)
- measurement (30416)
- notes (v0.9.4)
- public_transport (30416)
- reltoolbox (30587)
- reverter (30521)
- terracer (30614)
- turnrestrictions (30454)
- undelete (30416)
- utilsplugin2 (30460)

Last errors/warnings:
- W: Detected deprecated 'canvas{background-color}' in 'https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip' which will be removed shortly. Use 'fill-color' instead.

Attachments (0)

Change History (9)

comment:1 Changed 5 years ago by Don-vip

Cannot reproduce, can you please attach an .osm file, and the console output? Thanks.

comment:2 Changed 5 years ago by Klumbumbus

I cannot attach. I get the following error:

Oops …
Trac hat einen internen Fehler festgestellt:

IndexError: pop from empty list

Es ist ein interner Fehler aufgetreten. Bitte benachrichtigen Sie Ihren Trac-Administrator und fügen Sie eine Beschreibung an, wie der Fehler reproduziert werden kann.

Zu diesem Zweck können Sie auch ein Ticket .

Die Aktion, die den Fehler ausgelöst hat, war:

GET: /attachment/ticket/10513/

comment:3 Changed 5 years ago by Don-vip

I don't know what's wrong with Trac here. If it still does not work, can you please share the file somewhere else, or copy/paste the contents (I just want the node/way with the opening hours).

comment:4 Changed 5 years ago by Klumbumbus

<?xml version='1.0' encoding='UTF-8'?>
<osm version='0.6' upload='true' generator='JOSM'>
  <node id='-88' action='modify' visible='true' lat='50.09989412736' lon='14.39588494061'>
    <tag k='opening_hours' v='Mo-Su 09:00-21:00' />
  </node>
</osm>
Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:5 Changed 5 years ago by Klumbumbus

Java Web Start 10.67.2.01
JRE-Version verwenden 1.7.0_67-b01 Java HotSpot(TM) Client VM
Benutzer-Home-Verzeichnis = C:\Users\Stefan
----------------------------------------------------
INFO: Debug-Nachrichten werden auf der Konsole ausgegeben
DEBUG: System property 'http.agent' set to 'JOSM/1.5 (7533 de) Windows 7 32-Bit'. Old value was 'null'
DEBUG: System property 'user.language' set to 'en'. Old value was 'de'
DEBUG: System property 'jsse.enableSNIExtension' set to 'false'. Old value was 'null'
DEBUG: System property 'java.util.Arrays.useLegacyMergeSort' set to 'true'. Old value was 'true'
DEBUG: System property 'http.agent' set to 'JOSM/1.5 (7533 en) Windows 7 32-Bit'. Old value was 'JOSM/1.5 (7533 de) Windows 7 32-Bit'
DEBUG: System property 'user.language' set to 'en'. Old value was 'en'
DEBUG: System property 'jsse.enableSNIExtension' set to 'false'. Old value was 'false'
DEBUG: System property 'java.util.Arrays.useLegacyMergeSort' set to 'true'. Old value was 'true'
<snip>
DEBUG: Initializing validator tests
DEBUG: Initializing validator tests completed in 315 ms
DEBUG: Running test Addresses
DEBUG: Test 'Addresses' completed in 2 ms
DEBUG: Running test Barriers and entrances
DEBUG: Test 'Barriers and entrances' completed in 0 ms
DEBUG: Running test Coastlines
DEBUG: Test 'Coastlines' completed in 0 ms
DEBUG: Running test Conditional Keys
DEBUG: Test 'Conditional Keys' completed in 2 ms
DEBUG: Running test Crossing barriers
DEBUG: Test 'Crossing barriers' completed in 0 ms
DEBUG: Running test Crossing boundaries
DEBUG: Test 'Crossing boundaries' completed in 0 ms
DEBUG: Running test Crossing ways
DEBUG: Test 'Crossing ways' completed in 0 ms
DEBUG: Running test Duplicated nodes
DEBUG: Test 'Duplicated nodes' completed in 5 ms
DEBUG: Running test Duplicated relations
DEBUG: Test 'Duplicated relations' completed in 1 ms
DEBUG: Running test Duplicated ways
DEBUG: Test 'Duplicated ways' completed in 0 ms
DEBUG: Running test Duplicated way nodes
DEBUG: Test 'Duplicated way nodes' completed in 0 ms
DEBUG: Running test Highways
DEBUG: Test 'Highways' completed in 0 ms
DEBUG: Running test Internet tags
DEBUG: Test 'Internet tags' completed in 8 ms
DEBUG: Running test Lane tags
DEBUG: Test 'Lane tags' completed in 0 ms
DEBUG: Running test Tag checker (MapCSS based)
DEBUG: Test 'Tag checker (MapCSS based)' completed in 2 ms
DEBUG: Running test Multipolygon
DEBUG: Test 'Multipolygon' completed in 0 ms
DEBUG: Running test Missing name:* translation
DEBUG: Test 'Missing name:* translation' completed in 0 ms
DEBUG: Running test Opening hours syntax
DEBUG: no such method: prettifyValue
DEBUG: Test 'Opening hours syntax' completed in 49 ms
DEBUG: Running test Overlapping ways
DEBUG: Test 'Overlapping ways' completed in 0 ms
Last edited 5 years ago by Don-vip (previous) (diff)

comment:6 Changed 5 years ago by Don-vip

Keywords: java7 webstart added

OK I finally reproduce it, but it does only happen with Java 7 + Java Web Start. Sounds like a Java bug.

comment:7 Changed 5 years ago by Klumbumbus

There is the same error message also for collection_times.

comment:8 Changed 5 years ago by Don-vip

In 7537/josm:

see #10513 - opening_hours: replace prototype definition by standard function as a workaround to Java 7 / Webstart incompatibility

comment:9 Changed 5 years ago by Don-vip

Milestone: 14.09
Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.