Modify

Opened 5 years ago

Closed 4 years ago

#10512 closed enhancement (fixed)

Provide tag usage files for Taginfo

Reported by: bastiK Owned by: team
Priority: normal Milestone: 15.05
Component: Core Version:
Keywords: taginfo Cc: skyper, jochen@…, Klumbumbus

Description

As announced by Jochen Topf on josm-dev, Taginfo aggregates tag support from various OSM related projects. The information needs to be converted to a certain format. We can provide stats for:

  • presets
  • main mappaint style
  • validator rules

Attachments (1)

taginfo.json (132.7 KB) - added by bastiK 5 years ago.

Download all attachments as: .zip

Change History (50)

comment:1 Changed 5 years ago by bastiK

I'll have a go at the mappaint style part.

comment:2 Changed 5 years ago by skyper

Cc: skyper added

comment:3 Changed 5 years ago by bastiK

In 7544/josm:

see #10512 - taginfo: first version for mappaint style
only for node tags so far

Changed 5 years ago by bastiK

Attachment: taginfo.json added

comment:4 Changed 5 years ago by Don-vip

Milestone: 14.09

comment:5 Changed 5 years ago by bastiK

Cc: jochen@… added

comment:6 Changed 5 years ago by bastiK

See attachment: taginfo formatted json file for node tags in the main mappaint style.

comment:7 Changed 5 years ago by bastiK

In 7553/josm:

see #10512 - better taginfo support

comment:8 Changed 5 years ago by bastiK

In 7554/josm:

see #10512 - one more option

comment:10 Changed 5 years ago by Don-vip

Nice! :)

comment:11 Changed 5 years ago by stoecker

The JOSM cron already reads and parses all the external styles. If the groovy script could be adapted to support these files as well, we could call it from the cron job.

comment:12 Changed 5 years ago by bastiK

You'd need additional command line options to set the meta information at the beginning of the .json file, but otherwise it should work.

comment:13 Changed 5 years ago by Don-vip

Milestone: 14.0914.10

comment:14 Changed 4 years ago by Klumbumbus

Cc: Klumbumbus added

comment:15 Changed 4 years ago by Don-vip

Milestone: 14.1014.11

comment:16 Changed 4 years ago by Don-vip

Milestone: 14.1114.12

comment:17 Changed 4 years ago by Don-vip

Milestone: 14.1215.01

comment:18 Changed 4 years ago by Don-vip

Milestone: 15.0115.02

move tickets that have not been treated this month to next milestone

comment:19 Changed 4 years ago by Don-vip

Milestone: 15.0215.03

comment:20 Changed 4 years ago by stoecker

Milestone: 15.0315.04

Move one month.

comment:21 Changed 4 years ago by simon04

What is to be done for this ticket?

comment:22 Changed 4 years ago by Don-vip

Create new groovy scripts to report usage of tags in other files (validation rules, presets)

comment:23 Changed 4 years ago by Klumbumbus

and enhance it to work also for ways and areas (currently it works only for nodes afaik)

comment:24 in reply to:  23 ; Changed 4 years ago by bastiK

Replying to Klumbumbus:

and enhance it to work also for ways and areas (currently it works only for nodes afaik)

Nope, should also work for ways and areas.

TODO: Run this on external wiki-styles.

comment:25 Changed 4 years ago by simon04

In 8272/josm:

see #10512 - Use Groovy's JsonBuilder

comment:26 Changed 4 years ago by simon04

In 8273/josm:

see #10512 - taginfoextract: fix problem wrt layer name

Before, no object_types and icon_url have been extracted.

comment:27 Changed 4 years ago by simon04

In 8274/josm:

see #10512 - taginfoextract: add initial presets extration, switch all links to HTTPS

comment:28 Changed 4 years ago by bastiK

In 8275/josm:

see #10512 - compatibility with groovy 1.8.6

comment:29 Changed 4 years ago by stoecker

Milestone: 15.0415.05

comment:30 in reply to:  24 ; Changed 4 years ago by Klumbumbus

Replying to bastiK:

Replying to Klumbumbus:

and enhance it to work also for ways and areas (currently it works only for nodes afaik)

Nope, should also work for ways and areas.

Hm, I thought at the beginning of the projects tab on taginfo there were also the used icons displayed in the last column of the table. And some projects (not JOSM) did also display e.g. a colored line for a line feature like http://taginfo.openstreetmap.org/tags/highway=residential#projects

comment:31 in reply to:  27 ; Changed 4 years ago by bastiK

Replying to simon04:

In 8274/josm:

see #10512 - taginfoextract: add initial presets extration, switch all links to HTTPS

Presets included in daily cron job:
http://josm.openstreetmap.de/download/taginfo/taginfo_presets.json

comment:32 in reply to:  30 ; Changed 4 years ago by bastiK

Replying to Klumbumbus:

Replying to bastiK:

Replying to Klumbumbus:

and enhance it to work also for ways and areas (currently it works only for nodes afaik)

Nope, should also work for ways and areas.

Hm, I thought at the beginning of the projects tab on taginfo there were also the used icons displayed in the last column of the table. And some projects (not JOSM) did also display e.g. a colored line for a line feature like http://taginfo.openstreetmap.org/tags/highway=residential#projects

I don't see a colored line for any project in the last column.

comment:33 in reply to:  32 Changed 4 years ago by Klumbumbus

Replying to bastiK:

Replying to Klumbumbus:

Replying to bastiK:

Replying to Klumbumbus:

and enhance it to work also for ways and areas (currently it works only for nodes afaik)

Nope, should also work for ways and areas.

Hm, I thought at the beginning of the projects tab on taginfo there were also the used icons displayed in the last column of the table. And some projects (not JOSM) did also display e.g. a colored line for a line feature like http://taginfo.openstreetmap.org/tags/highway=residential#projects

I don't see a colored line for any project in the last column.

Me too. But I thought there were icons and colored lines one day.

comment:35 in reply to:  34 ; Changed 4 years ago by bastiK

comment:36 in reply to:  31 Changed 4 years ago by simon04

Replying to bastiK:

Presets included in daily cron job:
http://josm.openstreetmap.de/download/taginfo/taginfo_presets.json

Thank you! :)
I submitted a pull request for the inclusion: https://github.com/joto/taginfo-projects/pull/12

comment:37 Changed 4 years ago by bastiK

In 8280/josm:

see #10512 - fix spelling

comment:38 Changed 4 years ago by bastiK

In 8281/josm:

see #10512 - one more typo

comment:39 in reply to:  35 Changed 4 years ago by Klumbumbus

Replying to bastiK:

Replying to Klumbumbus:

Atleast node icons were displayed at the beginning. see screenshot at http://blog.jochentopf.com/2014-09-19-taginfo-integrates-more-data-sources.html. It is gone now http://taginfo.openstreetmap.org/tags/tourism=hotel#projects

And what about these icons http://josm.openstreetmap.de/download/taginfo/taginfo-img/way_highway=track.png?

I used to see icons here: http://taginfo.openstreetmap.org/projects/josm_main_mappaint_style#tags
This seems to be a taginfo problem.

It works now.

comment:40 Changed 4 years ago by Don-vip

Is it possible to move taginfoextact.groovy in scripts directory?

comment:41 Changed 4 years ago by bastiK

Yes, but then the path in the server Makefile needs to be fixed.

comment:42 Changed 4 years ago by Don-vip

That's why I ask :)

comment:43 Changed 4 years ago by bastiK

In 8306/josm:

see #10512 - move taginfoextract.groovy to scripts directory

comment:44 Changed 4 years ago by bastiK

Alright, alright... :)

comment:45 Changed 4 years ago by Don-vip

thanks :)

comment:46 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

I think we can close this ticket now. Validator rules are not so important because of the use of regular expressions and invalid tags.

comment:47 Changed 4 years ago by Klumbumbus

Would it be possible to include the icon also for the JOSM main presets http://taginfo.openstreetmap.org/tags/tourism=hotel#projects in front of the preset path?

comment:48 Changed 4 years ago by Don-vip

Resolution: fixed
Status: closedreopened

Sure. There's a bug, I'm on it.

comment:49 Changed 4 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 8439/josm:

fix #10512 - fix handling of icons from OSM SVN

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.