#10503 closed enhancement (fixed)
Note download code
| Reported by: | ToeBee | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.09 |
| Component: | Core notes | Version: | |
| Keywords: | Cc: |
Description
Well here is my core download code. You might want to give the first patch a little more scrutiny. The DownloadNotesTask class kind of got away from me. It works but on the other hand it has an abstract inner class which seems... odd. The whole download task code is kind of a maze of subclasses so when I got something that worked, I decided to submit what I have and see what others think.
The second patch is much simpler. It lets you actually download notes in the UI.
The first way is through the "Open Location" dialog which will now accept a URL with .osn or .osn.bz2 at the end. You can point it straight at http://planet.osm.org/notes/planet-notes-latest.osn.bz2 to see it in action.
The second way to download notes is to set the preference option osm.notes.enableDownload to true. This will mimic the eventual desired behavior of having a "Download Notes" checkbox in the standard download dialog. But since the notes layer obviously isn't ready for use yet I decided to do it with this hidden option for now.
Attachments (2)
Change History (6)
by , 11 years ago
| Attachment: | notesDownload.patch added |
|---|
by , 11 years ago
| Attachment: | enableDownload.patch added |
|---|
comment:1 by , 11 years ago
comment:2 by , 11 years ago
I believe you are correct. Apparently the API is rather forgiving in its parsing of parameters.
comment:4 by , 10 years ago
| Component: | Core → Core notes |
|---|---|
| Keywords: | notes removed |
Looks alright to me, are you missing an
=sign in the line?