Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10491 closed enhancement (fixed)

Add note icons

Reported by: ToeBee Owned by: team
Priority: normal Milestone: 14.09
Component: Core Version:
Keywords: Cc:

Description

I will have more note related patches soon. But in the mean time, I might as well get the icons added in. SVN patches don't do binary files so you will have to download and add these files yourself. In the plugin I'm using 16 and 22 pixel images. Most icons in core seem to be 16 and/or 24 pixels so I went with that. They can be seen here:
https://github.com/ToeBee/myjosm/tree/notes-download-task/images/notes

Attachments (0)

Change History (11)

comment:1 Changed 6 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7513/josm:

applied #10491 - Add note icons (patch by ToeBee)

comment:2 Changed 6 years ago by bastiK

What is the license of these icons? You can try if it looks okay to shrink the 22x22 px ones at runtime (to minimize the size of the binary). SVG is also supported (partially).

comment:3 Changed 6 years ago by Don-vip

Milestone: 14.09

comment:4 Changed 6 years ago by ToeBee

I got the original files off of the wiki where it says they are CC-BY-SA 2.0. The same icon design is also in use in the OSM rails port (also GPL).

comment:5 Changed 6 years ago by Don-vip

In 7519/josm:

see #10479, see #10491 - optimize notes images

comment:6 in reply to:  4 Changed 6 years ago by bastiK

Replying to ToeBee:

I got the original files off of the wiki where it says they are CC-BY-SA 2.0. The same icon design is also in use in the OSM rails port (also GPL).

Then we should contact the author and ask for permission to use under GPL or find replacement with suitable license.

On openclipart.org I can find this:

https://openclipart.org/image/300px/svg_to_png/177826/color_icons_green_home.png (link)

https://openclipart.org/image/300px/svg_to_png/169978/SagarShastry-PlaceMark.png (link)

comment:7 Changed 6 years ago by ToeBee

I asked in #osm-dev. Turns out, the wiki is wrong! Who would have guessed? Anyway, the icons are part of the rails port and as such are under GPLv2.

comment:8 Changed 6 years ago by bastiK

Hm, GPLv2 is not good, we need version 3 of the GPL. (The Apache 2.0 code we are using can be re-licensed to GPLv3, but not to GPLv2.)

comment:9 Changed 6 years ago by ToeBee

I sent an email to Leo (the author of the commit that added these icons to the rails port) asking if he would be willing to allow GPLv3. We can certainly use a generic marker icon like the one above but I would prefer to use the same one that people see on osm.org if possible.

comment:10 Changed 6 years ago by ToeBee

I got a response saying he is fine with GPLv3. Is this good enough or do I need to have him post that somewhere public or something?

comment:11 Changed 6 years ago by bastiK

No, I believe you. :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.