Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10490 closed enhancement (fixed)

Tracktype grade 5 nearly invisible on satelite imagery

Reported by: josm@… Owned by: Klumbumbus
Priority: normal Milestone: 14.12
Component: Internal mappaint style Version: tested
Keywords: template_report, track, tracktype, bridleway, steps Cc: bastiK, simon04, stoecker

Description (last modified by Don-vip)

Using imagery from Geoportal I've found grade5 tracks nearly invisible. I'm attaching a screenshot.


Revision: 7480
Repository Root: http://josm.openstreetmap.de/svn
Last Changed Author: Don-vip
Last Changed Date: 2014-08-31 23:51:24 +0200 (Sun, 31 Aug 2014)
Build-Date: 2014-08-31 21:55:55
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7480

Identification: JOSM/1.5 (7480 pl) Windows 8.1 64-Bit
Memory Usage: 927 MB / 1780 MB (325 MB allocated, but free)
Java version: 1.8.0_11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djosm.home=.josm/]
Dataset consistency test: No problems found

Plugins:
- PicLayer (30436)
- alignways (30416)
- buildings_tools (30485)
- editgpx (30416)
- measurement (30416)
- reverter (30521)
- turnrestrictions (30454)
- wikipedia (30449)

Last errors/warnings:
- E: Failed to locate image 'Waypoint'
- E: Failed to locate image 'Waypoint'
- E: Failed to locate image 'Waypoint'
- E: Failed to locate image 'Waypoint'
- E: java.io.IOException: Server returned HTTP response code: 502 for URL: http://mapy.geoportal.gov.pl/wss/service/img/guest/ORTO/MapServer/WMSServer?FORMAT=image/jpeg&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=Raster&STYLES=&SRS=EPSG:3857&WIDTH=500&HEIGHT=500&BBOX=2164417.1904022,6410677.5505898,2164525.8404293,6410786.2006169. Przyczyna: java.io.IOException: Server returned HTTP response code: 502 for URL: http://mapy.geoportal.gov.pl/wss/service/img/guest/ORTO/MapServer/WMSServer?FORMAT=image/jpeg&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=Raster&STYLES=&SRS=EPSG:3857&WIDTH=500&HEIGHT=500&BBOX=2164417.1904022,6410677.5505898,2164525.8404293,6410786.2006169

Attachments (4)

35967e3a1db8a510e20803a07f3b1785.png (60.3 KB) - added by josm@… 5 years ago.
trackcolorA.gif (12.9 KB) - added by Klumbumbus 5 years ago.
trackcolorB.gif (594.2 KB) - added by Klumbumbus 5 years ago.
elemstyles.mapcss.patch (1.2 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (21)

Changed 5 years ago by josm@…

comment:1 Changed 5 years ago by Don-vip

Component: External mappaint styleInternal mappaint style
Description: modified (diff)

comment:2 Changed 5 years ago by Klumbumbus

Keywords: track tracktype added
Milestone: 14.12
Owner: changed from team to Klumbumbus
Status: newassigned
Type: defectenhancement

comment:3 Changed 5 years ago by Klumbumbus

Cc: bastiK simon04 stoecker added

Tracks are often on forests of aerial imagery and therefore hard to see, (also tracktypes are hard to distinguish at the moment). I tried to make them more visible by adjusting dashes and width, but I noticed that this is not enough. So I suggest a color change of tracks to brown. Brown instead of green for tracks is in general more logic (since the surface of the track is more often brown or grey instead of green) and better distinguishable from paths and steps. I attached two comparison gifs and the patch file.

I would like to hear the opinions of the main developers (did I forget someone?) as this is some kind of a "big" change for the default mappaint style. I also tested this how it looks like with a desert aerial image background and I think that at least brown is not less visible than green there. It would be ok to delay this to the next milestone if there are any concerns.


(before and after with similar colored lines)



Last edited 5 years ago by Klumbumbus (previous) (diff)

Changed 5 years ago by Klumbumbus

Attachment: trackcolorA.gif added

Changed 5 years ago by Klumbumbus

Attachment: trackcolorB.gif added

Changed 5 years ago by Klumbumbus

Attachment: elemstyles.mapcss.patch added

comment:4 Changed 5 years ago by Don-vip

I find this really nice :)

comment:5 Changed 5 years ago by josm@…

I'm also satisfied by the changes :)

comment:6 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 7900/josm:

fix #10490 - improve visibility of highway=track on aerial imagery background (change width, dashes and color from green to brown); better distinction between different tracktype and steps

comment:7 Changed 5 years ago by Klumbumbus

Keywords: bridleway steps added

comment:8 Changed 5 years ago by rickmastfan67

Just saw the following 'errors' in the Command Line here on Windows 7 x64 SP1 using [7900] that are related to this changeset.

INFO: Defaults for color.mappaint.josm.default.mapcss.highway.track differ: #6E541C != #006600
INFO: Defaults for color.mappaint.josm.default.mapcss.highway.track differ: #006600 != #6E541C

Tried to 'deleted' the "JOSM default (MapCSS)" entry in "Map Paint Styles", and restart, then add it back, and restart again and still couldn't get this to clear.

Maybe there was another entry for this that failed to get updated causing this problem?

comment:9 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Thanks for the info. I forgot to change area fill color and text halo color. I can fix this tonight.

comment:10 Changed 5 years ago by Don-vip

I have initialized the changelog here: wiki/Changelog

I do not have added all the enhancements you have made to map styles, presets and validator as you know them better than me :) Can you please update the list after you fix this last ticket? Thanks :)

comment:11 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 7904/josm:

fix #10490 - fix color change of highway=track

comment:12 Changed 5 years ago by mdk

Can we change the color of highway=bridleway? Now it looks nearly the same like highway=track.
And often, bridleway is wrongly used, where highway=track would be correct like here: http://overpass-turbo.eu/s/6IA or where highway=path/footway would be correct like here: http://overpass-turbo.eu/s/6IB. And now I will miss these failures.

Last edited 5 years ago by mdk (previous) (diff)

comment:13 in reply to:  12 Changed 5 years ago by Klumbumbus

Replying to mdk:

Can we change the color of highway=bridleway? Now it looks nearly the same like highway=track.
And often, bridleway is wrongly used, where highway=track would be correct like here: http://overpass-turbo.eu/s/6IA or where highway=path/footway would be correct like here: http://overpass-turbo.eu/s/6IB. And now I will miss these failures.

I already changed the color of bridleway in r7900 to make it more distinguishable from the new highway=track color (see both example images). In my opinion it is ok this way. You can suggest a better color, but make sure, that it is distinguishable from the similar colored other way colors and the yellow waynodes and plus signs. Briddleways are also often in forests, so a green color would't be a good choice in my opinion (because aerial imagery background).

comment:14 in reply to:  10 Changed 5 years ago by Klumbumbus

Replying to Don-vip:

Can you please update the list after you fix this last ticket?

Done.

comment:15 Changed 5 years ago by Don-vip

Thanks! Releasing on time then :)

comment:16 Changed 5 years ago by anonymous

Brown instead of green for tracks is in general more logic (since the surface of the track is more often brown or grey instead of green)

It means that with aerial image as background track will be more likely to be invisible. Old version have problems in forests, but it is replacing one problem with another.

comment:17 in reply to:  16 Changed 5 years ago by Klumbumbus

Replying to anonymous:

Brown instead of green for tracks is in general more logic (since the surface of the track is more often brown or grey instead of green)

It means that with aerial image as background track will be more likely to be invisible. Old version have problems in forests, but it is replacing one problem with another.

I couldn't find an example where it is now less visible than before. And even if there a some examples, the total number of tracks with visibility problems was extremely reduced.

#6E541C is not a typical color of a highway=track of a aerial imagery. It is more something like #ad917b

Feel free to change the color of highway=track in the JOSM settings if you think the current default color is not good or to make an improvement suggestion.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.