Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10468 closed defect (fixed)

Highway label issues in new map style [patch]

Reported by: AMDmi3 Owned by: team
Priority: normal Milestone: 14.09
Component: Internal mappaint style Version: tested
Keywords: Cc: Klumbumbus

Description (last modified by Don-vip)

New map style brings several problems:

1) It's dependent on zoom. This is not acceptable for advanced editor, as a mapper should always see all objects in area on any zoom, including their types (e.g. icons) and complexity (e.g. nodes). At least there should be an option to do so.

2) Road labels are unreadable when antialiasing is disabled (and here it is disabled, as JOSM is too slow to render dense map data even without it). There's no way to disable labels either.

I haven't found a way to fix these problems in the style, it seems that zooms and labels are handled inside the renderer. I haven't found any relevant knobs in `Advanced Preferences' either. So for now there's no other way than to stick with old XML style.

So, minimal customization abilities should be added, which don't look too complex:

  • an option to fix zoom level for renderer
  • an option to disable labels for ways

Attachments (2)

neefestraße.png (144.9 KB) - added by Klumbumbus 5 years ago.
7470 style setting display_street_labels.diff (515 bytes) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 in reply to:  description Changed 5 years ago by bastiK

Replying to AMDmi3:

New map style brings several problems:

1) It's dependent on zoom. This is not acceptable for advanced editor, as a mapper should always see all objects in area on any zoom, including their types (e.g. icons) and complexity (e.g. nodes). At least there should be an option to do so.

This can be configured, see style settings.

2) Road labels are unreadable when antialiasing is disabled (and here it is disabled, as JOSM is too slow to render dense map data eevn without it). There's no way to disable labels either.

Could you describe the machine where you have performance problems (CPU, memory)? Please add a status report.

comment:2 Changed 5 years ago by Don-vip

Description: modified (diff)
Summary: New map style dependent on zoom, not customizableHighway label issues in new map style

comment:3 Changed 5 years ago by AMDmi3

This can be configured, see style settings.

This works, thanks. However, the location of that settings is really counter-intuitive - I would never open Map Paint Styles window. It probably should be either in Preferences or View->Map paint styles menu.

Could you describe the machine where you have performance problems (CPU, memory)? Please add a status report.

I don't think that has anything to do with my environment. I just work with large data sets.

comment:4 in reply to:  3 Changed 5 years ago by Don-vip

Replying to AMDmi3:

the location of that settings is really counter-intuitive [...] It probably should be either in Preferences or View->Map paint styles menu.

This is discussed in #10435.

comment:5 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:6 Changed 5 years ago by Klumbumbus

Component: Core mappaintInternal mappaint style

Changed 5 years ago by Klumbumbus

Attachment: neefestraße.png added

comment:7 Changed 5 years ago by Klumbumbus

I think one more style setting to hide the street labels on all zoom levels would be good. The labels can sometimes be distracting also on high zoom levels, see example screenshot:


Changed 5 years ago by Klumbumbus

comment:8 Changed 5 years ago by Klumbumbus

Summary: Highway label issues in new map styleHighway label issues in new map style [patch]

I made a patch for this.

comment:9 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7520/josm:

applied #10468 - Highway label issues in new map style (based on patch by Klumbumbus)

comment:10 in reply to:  8 Changed 5 years ago by bastiK

Replying to Klumbumbus:

I made a patch for this.

Thanks! The changes I did are with efficiency in mind. The idea is that simple style conditions need not be evaluated at runtime, but there could be a pre-processing step. Any rules where the setting condition does not match can be removed from the style sheet in advance. (Not implemented yet.)

comment:11 Changed 5 years ago by Don-vip

Milestone: 14.09

comment:12 Changed 5 years ago by anonymous

Thank you! The style is now usable. Now the only regression to the old style I can notice is that selected nodes are not filled (and mappaint.node.fill-selected doesn't affect it), but this is very minor.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.