Include object type and id in history for undecorated windows

[naoliv]

Can the object type (node, way, relation) and id be included in the history panel (Ctrl+h)?
It would be very helpful to compare some object history:

[Don-vip]

I don't get it, we already display object types? Could you please attach an UI mockup of what you'd like to see?

[naoliv]

For example, I can deduce that this object in the history dialog is a way because it has a "Nodes" tab, but nowhere it's explicitly saying that this history is of a way. Also, we can't see the object id (only versions and changesets, but not its id). Maybe this info could be included like the example in red? (with a better presentation, of course)

[Don-vip]

On usual setups this information is displayed in title bar. Did you remove decorations for all windows?

[naoliv]

Hum... my window manager doesn't have decorations :-)
It's only a tiny 1 px border, without buttons and titles.

[Don-vip]

Replying to naoliv:

Hum... my window manager doesn't have decorations :-)

Which one is it?

[naoliv]

It's ​http://awesome.naquadah.org/
Just in case you look at the screenshots, while there is a kind of title bar at the top of the environment, the history window doesn't display anything there.

[Don-vip]

Thanks. It's a similar issue to #8664. I don't know how to fix it (i.e detect that the dialog is undecorated).

[Don-vip]

In 7524/josm:

see #10462 - add debug stuff

[Don-vip]

In 7527/josm:

see #10462 - more debug stuff, improve javadoc

[Don-vip]

@naoliv, @skyper:
Can you please, both of you, display an history dialog (for any object) with your respective window manager that does not provide window decoration, with josm latest (I just have rebuilt it right now) in debug mode (java -jar josm-latest.jar --debug) and share the following console output for your system? Thanks.

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Microsoft Windows Look and Feel - com.sun.java.swing.plaf.windows.WindowsLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: false
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2351843378
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=31,left=8,bottom=8,right=8]

[naoliv]

This is what I have here:

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Java(tm) Look and Feel - javax.swing.plaf.metal.MetalLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: true
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: Histórico para nó 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=0,left=0,bottom=0,right=0]

It is for node 2394175555

[skyper]

Gnome 3 on Debian 7.6 (wheezy):

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Java(tm) Look and Feel - javax.swing.plaf.metal.MetalLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: true
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=25,left=5,bottom=5,right=5]

[skyper]

tried with GTK look and feel aswell:

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [GTK look and feel - com.sun.java.swing.plaf.gtk.GTKLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: false
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=32,left=1,bottom=1,right=1]

[Don-vip]

In 7528/josm:

fix #10462 - Include object type and id in history for undecorated windows

[naoliv]

Needs to do the same thing for the Conflicts dialog.

[Don-vip]

In 7586/josm:

fix #10462 - Include object type and id in conflict dialog for undecorated windows