Modify

Opened 5 years ago

Closed 5 years ago

#10462 closed enhancement (fixed)

Include object type and id in history for undecorated windows

Reported by: naoliv Owned by: naoliv
Priority: normal Milestone: 14.09
Component: Core Version:
Keywords: decoration history dialog Cc: skyper

Description (last modified by Don-vip)

Can the object type (node, way, relation) and id be included in the history panel (Ctrl+h)?
It would be very helpful to compare some object history:

For example, I can deduce that this object in the history dialog is a way because it has a "Nodes" tab, but nowhere it's explicitly saying that this history is of a way. Also, we can't see the object id (only versions and changesets, but not its id). Maybe this info could be included like the example in red? (with a better presentation, of course)

Attachments (2)

history.png (51.2 KB) - added by naoliv 5 years ago.
For example, I can deduce that this object in the history dialog is a way because it has a "Nodes" tab, but nowhere it's explicitly saying that this history is of a way. Also, we can't see the object id (only versions and changesets, but not its id). Maybe this info could be included like the example in red? (with a better presentation, of course)
history_titlebar.png (17.4 KB) - added by Don-vip 5 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 5 years ago by Don-vip

Owner: changed from team to naoliv
Status: newneedinfo

I don't get it, we already display object types? Could you please attach an UI mockup of what you'd like to see?

Changed 5 years ago by naoliv

Attachment: history.png added

For example, I can deduce that this object in the history dialog is a way because it has a "Nodes" tab, but nowhere it's explicitly saying that this history is of a way. Also, we can't see the object id (only versions and changesets, but not its id). Maybe this info could be included like the example in red? (with a better presentation, of course)

comment:2 Changed 5 years ago by Don-vip

Description: modified (diff)

Changed 5 years ago by Don-vip

Attachment: history_titlebar.png added

comment:3 Changed 5 years ago by Don-vip

On usual setups this information is displayed in title bar. Did you remove decorations for all windows?


comment:4 Changed 5 years ago by naoliv

Hum... my window manager doesn't have decorations :-)
It's only a tiny 1 px border, without buttons and titles.

comment:5 in reply to:  4 Changed 5 years ago by Don-vip

Keywords: decoration history dialog added
Summary: Include object type and id in historyInclude object type and id in history for undecorated windows

Replying to naoliv:

Hum... my window manager doesn't have decorations :-)

Which one is it?

comment:6 Changed 5 years ago by naoliv

It's http://awesome.naquadah.org/
Just in case you look at the screenshots, while there is a kind of title bar at the top of the environment, the history window doesn't display anything there.

comment:7 Changed 5 years ago by Don-vip

Owner: changed from naoliv to team
Status: needinfonew

Thanks. It's a similar issue to #8664. I don't know how to fix it (i.e detect that the dialog is undecorated).

comment:8 Changed 5 years ago by Don-vip

In 7524/josm:

see #10462 - add debug stuff

comment:9 Changed 5 years ago by skyper

Cc: skyper added

comment:11 Changed 5 years ago by Don-vip

In 7527/josm:

see #10462 - more debug stuff, improve javadoc

comment:12 Changed 5 years ago by Don-vip

Owner: changed from team to naoliv
Status: newneedinfo

@naoliv, @skyper:
Can you please, both of you, display an history dialog (for any object) with your respective window manager that does not provide window decoration, with josm latest (I just have rebuilt it right now) in debug mode (java -jar josm-latest.jar --debug) and share the following console output for your system? Thanks.

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Microsoft Windows Look and Feel - com.sun.java.swing.plaf.windows.WindowsLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: false
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2351843378
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=31,left=8,bottom=8,right=8]

comment:13 Changed 5 years ago by Don-vip

Milestone: 14.09

comment:14 Changed 5 years ago by naoliv

This is what I have here:

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Java(tm) Look and Feel - javax.swing.plaf.metal.MetalLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: true
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: Histórico para nó 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=0,left=0,bottom=0,right=0]

It is for node 2394175555

Last edited 5 years ago by naoliv (previous) (diff)

comment:15 Changed 5 years ago by skyper

Gnome 3 on Debian 7.6 (wheezy):

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [The Java(tm) Look and Feel - javax.swing.plaf.metal.MetalLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: true
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=25,left=5,bottom=5,right=5]

comment:16 Changed 5 years ago by skyper

tried with GTK look and feel aswell:

DEBUG: #10462 - JDialog.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - JFrame.isDefaultLookAndFeelDecorated: false
DEBUG: #10462 - dialog.isUndecorated: false
DEBUG: #10462 - UIManager.getLookAndFeel: [GTK look and feel - com.sun.java.swing.plaf.gtk.GTKLookAndFeel]
DEBUG: #10462 - LookAndFeel.getSupportsWindowDecorations: false
DEBUG: #10462 - JRootPane.getWindowDecorationStyle: 0
DEBUG: #10462 - Window.getIconImages: []
DEBUG: #10462 - Dialog.getTitle: History for node 2394175555
DEBUG: #10462 - Dialog.getInsets: java.awt.Insets[top=32,left=1,bottom=1,right=1]

comment:17 Changed 5 years ago by Don-vip

Resolution: fixed
Status: needinfoclosed

In 7528/josm:

fix #10462 - Include object type and id in history for undecorated windows

comment:18 Changed 5 years ago by naoliv

Resolution: fixed
Status: closedreopened

Needs to do the same thing for the Conflicts dialog.

comment:19 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 7586/josm:

fix #10462 - Include object type and id in conflict dialog for undecorated windows

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain naoliv.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.