Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#10346 closed enhancement (fixed)

drop rendering of bridge/tunnel/oneway = true/1

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 15.03
Component: Internal mappaint style Version:
Keywords: Cc:

Description

Currently elemstyles.mapcss is often written like way[bridge?]{} So it also renders for bridge=true and bridge=1. I think this is bad tagging because only "yes" should be used. Same for tunnel, oneway, noexit, motorroad, area, ford,... I would change this to way[bridge=yes]{}. Same for the other keys. I would create the diff file, if it gets accepted. I just want to ask before I do the work.

Attachments (0)

Change History (8)

comment:1 Changed 5 years ago by Don-vip

I agree this is bad tagging but I don't think this is worth the trouble.

comment:2 Changed 5 years ago by naoliv

It should not be dropped at the rendering, but fixed in the data itself.
Or, if you like, have another validator rule for these values (which could also include a fix for true|1yes)

comment:3 Changed 5 years ago by Don-vip

Resolution: wontfix
Status: newclosed

There is no added value in changing the rendering, let's keep it as it is.
I checked the numbers of *=true, this tag is already very uncommon, and does not need a specific test neither.

comment:4 Changed 4 years ago by Klumbumbus

Resolution: wontfixfixed

In 8137/josm:

fix #10346 - drop rendering of bridge/tunnel/noexit/motorroad = true/1, add validator warning for oneway=1

comment:5 Changed 4 years ago by Klumbumbus

Milestone: 15.03

Only some minor changes.

comment:6 in reply to:  3 Changed 4 years ago by stoecker

Replying to Don-vip:

I checked the numbers of *=true, this tag is already very uncommon, and does not need a specific test neither.

I'm happy that I succeeded here. It was my decision that I don't like multiple boolean values and JOSM should only produce yes and no whenever possible. :-) JOSM has influence!

comment:7 in reply to:  description ; Changed 4 years ago by aceman

Replying to Klumbumbus:

Currently elemstyles.mapcss is often written like way[bridge?]{} So it also renders for bridge=true and bridge=1. I think this is bad tagging because only "yes" should be used.

You mean bridge=yes and bridge=<some of the different types of bridge> is to be supported.

comment:8 in reply to:  7 Changed 4 years ago by Klumbumbus

Replying to aceman:

You mean bridge=yes and bridge=<some of the different types of bridge> is to be supported.

Yes, see http://josm.openstreetmap.de/browser/josm/trunk/styles/standard/elemstyles.mapcss#L111 for supportet values.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.