missing type=closedway for several highways in data/defaultpresets.xml

[anonymous]

I noticed missing "closedway" in "type=way" for several highways in data/defaultpresets.xml. This results in a greyed-out preset dialog.

Those are at least highway=motorway,motorway_link,primary,primary_link,secondary,secondary_link,tertiary,tertiary_link.

[Don-vip]

#8663 is somewhat related, but I don't see how is that a problem. A closed motorway, really? A closed link? It does not really make sense.

[skyper]

Replying to Don-vip:

#8663 is somewhat related, but I don't see how is that a problem. A closed motorway, really? A closed link? It does not really make sense.

The behaviour did change and closedways are not included in ways anymore, e.g. primary, secondary and tertiary need closedway. Think about roundabounds and other circle or squares with oneway roads around it.

[skyper]

Forgot:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-07-11 01:36:22
Last Changed Author: Don-vip
Revision: 7303
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-07-11 02:59:09 +0200 (Fri, 11 Jul 2014)
Last Changed Rev: 7303

Identification: JOSM/1.5 (7303 en) Linux Debian GNU/Linux 7.6 (wheezy)
Memory Usage: 297 MB / 882 MB (201 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u55-2.4.7-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30519)
Plugin: conflation (0.1.7)
Plugin: imagery-xml-bounds (30495)
Plugin: jts (30416)
Plugin: mirrored_download (30495)
Plugin: notes (v0.9.2)
Plugin: photoadjust (30428)
Plugin: reverter (30436)
Plugin: terracer (30416)
Plugin: todo (29154)
Plugin: undelete (30416)
Plugin: utilsplugin2 (30460)
Plugin: wikipedia (30449)

[Don-vip]

mmm yes ok for these three.

[Don-vip]

In 7306/josm:

fix #10259 - presets: allow closedway for highway=primary/secondary/tertiary