Modify

Opened 5 years ago

Closed 5 years ago

#10140 closed enhancement (fixed)

Add new validation rule- consider building:levels on nodes as invalid

Reported by: Xxzme Owned by: team
Priority: minor Milestone: 14.06
Component: Core validator Version: latest
Keywords: Cc:

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by Don-vip

Component: unspecifiedCore validator

comment:2 Changed 5 years ago by bastiK

There are two parts to this:

(1) building:levels without building or building:part
(2) building on a node.

(1) seems reasonable to me.

However I would reject (2): there are already 743941 nodes tagged with building=*. Even though it isn't allowed according to the wiki, there might be good reasons for this, e.g. if you want to tag the number of levels for a building, but there is no aerial imagery to trace the outline.

comment:3 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7243/josm:

fixed #10140 - validation rule for building:levels

comment:4 Changed 5 years ago by Don-vip

Milestone: 14.06

comment:5 Changed 5 years ago by anonymous

Thanks! Maybe this should be expanded to warn about any 'building:*' without 'building' or 'building:part' ?

comment:6 Changed 5 years ago by Xxzme

Resolution: fixed
Status: closedreopened

bastiK, well you talk about different case. My case irrelevant to houses mapped as single point.

My original case:
way 1000 contains points 2000, 2001.
way 1000 have tag building=yes
points 2000 and 2001 have tag building:levels

Validator should warn if point that part of way with building=* tagged as building:levels.

comment:7 Changed 5 years ago by anonymous

Another case:
way 1000 contains points 2000, 2001.
way 1000 tagged as building=* and building:levels=*
points 2000 and (or?) 2001 have tag building:levels=*

comment:8 Changed 5 years ago by anonymous

Summary: Add new validation ruleAdd new validation rule- consider building:levels on nodes as invalid

comment:9 Changed 5 years ago by bastiK

@Xxzme: These cases should be covered by the new validation rule.

comment:10 Changed 5 years ago by Xxzme

Well, but they are not fixed by changeset 7243...

comment:11 Changed 5 years ago by bastiK

Please explain, what you think is missing.

comment:12 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.