Changeset 7613 in josm for trunk/src/org/openstreetmap

Timestamp:

2014-10-13T22:25:59+02:00 (10 years ago)

Author:

Don-vip

Message:

see #8995, fix #10630 - change keyvalue match meaning to "neutral otherwise", add new keyvalue! match mode by default with the old meaning (negative otherwise)

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

@@ -254 +254 @@
         /** Positive if key matches, negative otherwise. */
         KEY_REQUIRED("key!"),
+        /** Positive if key and value matches, neutral otherwise. */
+        KEY_VALUE("keyvalue"),
         /** Positive if key and value matches, negative otherwise. */
-        KEY_VALUE("keyvalue");
+        KEY_VALUE_REQUIRED("keyvalue!");
 
         private final String value;
@@ -550 +552 @@
                 return tags.containsKey(key);
             case KEY_VALUE:
-                return tags.containsKey(key) && (getValues().contains(tags.get(key)));
+                return tags.containsKey(key) && getValues().contains(tags.get(key)) ? true : null;
+            case KEY_VALUE_REQUIRED:
+                return tags.containsKey(key) && getValues().contains(tags.get(key));
             default:
                 throw new IllegalStateException();
@@ -584 +588 @@
         @Override
         public MatchType getDefaultMatch() {
-            return MatchType.KEY_VALUE;
+            return MatchType.KEY_VALUE_REQUIRED;
         }