Changeset 18637 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2023-01-17T15:05:33+01:00 (2 years ago)

Author:

taylor.smock

Message:

See #18230: Move RightAngleBuildingTest error code to 4101 from 3701.

This is due to clashing with an error code from pt_assistant.

See also #21423: Ensure validator codes are unique -- replace missed
since xxx with since 18636.

Location:

trunk/src/org/openstreetmap/josm/data/validation

Files:

• OsmValidator.java (modified) (1 diff)
• TestError.java (modified) (1 diff)
• tests/RightAngleBuildingTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -152 +152 @@
         LongSegment.class, // 3500 .. 3599
         PublicTransportRouteTest.class, // 3600 .. 3699
-        RightAngleBuildingTest.class, // 3700 .. 3799
+        // 3700 .. 3799 is automatically removed since it clashed with pt_assistant.
         SharpAngles.class, // 3800 .. 3899
         ConnectivityRelations.class, // 3900 .. 3999
         DirectionNodes.class, // 4000-4099
+        RightAngleBuildingTest.class, // 4100 .. 4199
     };
 

trunk/src/org/openstreetmap/josm/data/validation/TestError.java

@@ -490 +490 @@
      * Get the unique code for this test. Used for ignore lists.
      * @return The unique code (generated with {@code tester.getClass().getName().hashCode() + code}).
-     * @since xxx
+     * @since 18636
      */
     public int getUniqueCode() {

trunk/src/org/openstreetmap/josm/data/validation/tests/RightAngleBuildingTest.java

@@ -44 +44 @@
         for (Pair<Double, Node> pair: angles) {
             if (checkAngle(pair.a)) {
-                TestError.Builder builder = TestError.builder(this, Severity.OTHER, 3701)
+                TestError.Builder builder = TestError.builder(this, Severity.OTHER, 4101)
                                                      .message(tr("Building with an almost square angle"))
                                                      .primitives(w)