Changeset 16774 in josm

Timestamp:

2020-07-15T21:00:18+02:00 (4 years ago)

Author:

simon04

Message:

fix #19293 - Tag2link/wikipedia: replace space with underscore

Location:

trunk

Files:

• src/org/openstreetmap/josm/tools/Tag2Link.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/tools/Tag2LinkTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/Tag2Link.java

@@ -156 +156 @@
         if (keyMatcher.matches() && valueMatcher.matches()) {
             final String lang = Utils.firstNotEmptyString("en", keyMatcher.group("lang"), valueMatcher.group("lang"));
-            linkConsumer.acceptLink(tr("View Wikipedia article"), "https://" + lang + ".wikipedia.org/wiki/" + valueMatcher.group("article"));
+            final String url = "https://" + lang + ".wikipedia.org/wiki/" + valueMatcher.group("article").replace(' ', '_');
+            linkConsumer.acceptLink(tr("View Wikipedia article"), url);
         }
         if (key.matches("(.*:)?wikidata")) {

trunk/test/unit/org/openstreetmap/josm/tools/Tag2LinkTest.java

@@ -52 +52 @@
      */
     @Test
+    public void testWikipedia() {
+        Tag2Link.getLinksForTag("wikipedia", "de:Wohnhausgruppe Herderstraße", this::addLink);
+        checkLinks("View Wikipedia article // https://de.wikipedia.org/wiki/Wohnhausgruppe_Herderstraße");
+        links.clear();
+        Tag2Link.getLinksForTag("wikipedia", "de:Stadtbahn Köln#Innenstadttunnel", this::addLink);
+        checkLinks("View Wikipedia article // https://de.wikipedia.org/wiki/Stadtbahn_Köln#Innenstadttunnel");
+    }
+
+    /**
+     * Unit test of function {@link Tag2Link#getLinksForTag}.
+     */
+    @Test
     public void testImageCommonsImage() {
         Tag2Link.getLinksForTag("image", "File:Witten Brücke Gasstraße.jpg", this::addLink);