Changeset 13497 in josm for trunk

Timestamp:

2018-03-04T15:18:05+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #16051, see #8039, see #10456 - more fixes for download/upload policies and locked status (merge of layers)

Location:

trunk

Files:

• src/org/openstreetmap/josm/actions/UpdateModifiedAction.java (modified) (2 diffs)
• src/org/openstreetmap/josm/actions/UploadSelectionAction.java (modified) (3 diffs)
• src/org/openstreetmap/josm/data/osm/DataSet.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/DataSetMerger.java (modified) (3 diffs)
• src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/osm/DataSetTest.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/UpdateModifiedAction.java

@@ -11 +11 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.osm.DataSet;
+import org.openstreetmap.josm.data.osm.DataSet.DownloadPolicy;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.io.OnlineResource;
@@ -46 +47 @@
     @Override
     protected void updateEnabledState() {
-        setEnabled(getLayerManager().getEditDataSet() != null && !Main.isOffline(OnlineResource.OSM_API));
+        DataSet ds = getLayerManager().getEditDataSet();
+        setEnabled(ds != null && !DownloadPolicy.BLOCKED.equals(ds.getDownloadPolicy())
+                && !Main.isOffline(OnlineResource.OSM_API));
     }
 

trunk/src/org/openstreetmap/josm/actions/UploadSelectionAction.java

@@ -64 +64 @@
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
         updateEnabledStateOnModifiableSelection(selection);
+        OsmDataLayer editLayer = getLayerManager().getEditLayer();
+        if (editLayer != null && !editLayer.isUploadable()) {
+            setEnabled(false);
+        }
     }
 
@@ -89 +93 @@
     public void actionPerformed(ActionEvent e) {
         OsmDataLayer editLayer = getLayerManager().getEditLayer();
-        if (!isEnabled())
+        if (!isEnabled() || !editLayer.isUploadable())
             return;
         if (editLayer.isUploadDiscouraged() && UploadAction.warnUploadDiscouraged(editLayer)) {
@@ -203 +207 @@
                 hull.add(w);
                 for (Node n: w.getNodes()) {
-                    // we upload modified nodes even if they aren't in the current
-                    // selection.
+                    // we upload modified nodes even if they aren't in the current selection.
                     n.accept(this);
                 }

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -329 +329 @@
             version = copyFrom.version;
             uploadPolicy = copyFrom.uploadPolicy;
+            downloadPolicy = copyFrom.downloadPolicy;
             isReadOnly.set(copyFrom.isReadOnly.get());
         } finally {

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.awt.geom.Area;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -14 +15 @@
 import java.util.Set;
 
+import org.openstreetmap.josm.data.DataSource;
 import org.openstreetmap.josm.data.conflict.Conflict;
 import org.openstreetmap.josm.data.conflict.ConflictCollection;
@@ -432 +434 @@
             candidates.clear();
             fixReferences();
+
+            Area a = targetDataSet.getDataSourceArea();
+
+            // copy the merged layer's data source info.
+            // only add source rectangles if they are not contained in the layer already.
+            for (DataSource src : sourceDataSet.getDataSources()) {
+                if (a == null || !a.contains(src.bounds.asRect())) {
+                    targetDataSet.addDataSource(src);
+                }
+            }
+
+            // copy the merged layer's API version
+            if (targetDataSet.getVersion() == null) {
+                targetDataSet.setVersion(sourceDataSet.getVersion());
+            }
+
+            // copy the merged layer's policies and locked status
+            if (sourceDataSet.getUploadPolicy() != null && (targetDataSet.getUploadPolicy() == null
+                    || sourceDataSet.getUploadPolicy().compareTo(targetDataSet.getUploadPolicy()) > 0)) {
+                targetDataSet.setUploadPolicy(sourceDataSet.getUploadPolicy());
+            }
+            if (sourceDataSet.getDownloadPolicy() != null && (targetDataSet.getDownloadPolicy() == null
+                    || sourceDataSet.getDownloadPolicy().compareTo(targetDataSet.getDownloadPolicy()) > 0)) {
+                targetDataSet.setDownloadPolicy(sourceDataSet.getDownloadPolicy());
+            }
+            if (sourceDataSet.isLocked() && !targetDataSet.isLocked()) {
+                targetDataSet.lock();
+            }
         } finally {
             targetDataSet.endUpdate();

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -552 +552 @@
         }
 
-        Area a = data.getDataSourceArea();
-
-        // copy the merged layer's data source info.
-        // only add source rectangles if they are not contained in the layer already.
-        for (DataSource src : from.getDataSources()) {
-            if (a == null || !a.contains(src.bounds.asRect())) {
-                data.addDataSource(src);
-            }
-        }
-
-        // copy the merged layer's API version
-        if (data.getVersion() == null) {
-            data.setVersion(from.getVersion());
-        }
-
         int numNewConflicts = 0;
         for (Conflict<?> c : visitor.getConflicts()) {

trunk/test/unit/org/openstreetmap/josm/data/osm/DataSetTest.java

@@ -3 +3 @@
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
@@ -14 +15 @@
 import org.junit.Test;
 import org.openstreetmap.josm.data.coor.LatLon;
+import org.openstreetmap.josm.data.osm.DataSet.DownloadPolicy;
 import org.openstreetmap.josm.data.osm.DataSet.UploadPolicy;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
@@ -194 +196 @@
     }
 
+    /**
+     * Unit test for {@link DataSet#mergeFrom} - Policies.
+     */
+    @Test
+    public void testMergePolicies() {
+        DataSet ds1 = new DataSet();
+        DataSet ds2 = new DataSet();
+
+        ds1.setUploadPolicy(UploadPolicy.BLOCKED);
+        ds2.setUploadPolicy(UploadPolicy.NORMAL);
+        ds1.mergeFrom(ds2);
+        assertEquals(UploadPolicy.BLOCKED, ds1.getUploadPolicy());
+
+        ds1.setUploadPolicy(UploadPolicy.NORMAL);
+        ds2.setUploadPolicy(UploadPolicy.BLOCKED);
+        ds1.mergeFrom(ds2);
+        assertEquals(UploadPolicy.BLOCKED, ds1.getUploadPolicy());
+
+        ds1.setDownloadPolicy(DownloadPolicy.BLOCKED);
+        ds2.setDownloadPolicy(DownloadPolicy.NORMAL);
+        ds1.mergeFrom(ds2);
+        assertEquals(DownloadPolicy.BLOCKED, ds1.getDownloadPolicy());
+
+        ds1.setDownloadPolicy(DownloadPolicy.NORMAL);
+        ds2.setDownloadPolicy(DownloadPolicy.BLOCKED);
+        ds1.mergeFrom(ds2);
+        assertEquals(DownloadPolicy.BLOCKED, ds1.getDownloadPolicy());
+
+        ds2.lock();
+        assertFalse(ds1.isLocked());
+        assertTrue(ds2.isLocked());
+        ds1.mergeFrom(ds2);
+        assertTrue(ds1.isLocked());
+    }
+
     private static void assertEqualsDataSet(DataSet ds1, DataSet ds2) {
         assertEquals(new ArrayList<>(ds1.getNodes()), new ArrayList<>(ds2.getNodes()));
@@ -202 +239 @@
         assertEquals(ds1.getVersion(), ds2.getVersion());
     }
+
+    /**
+     * Checks that enum values are defined in the correct order.
+     */
+    @Test
+    public void testEnumOrder() {
+        assertTrue(DownloadPolicy.BLOCKED.compareTo(DownloadPolicy.NORMAL) > 0);
+        assertTrue(UploadPolicy.BLOCKED.compareTo(UploadPolicy.NORMAL) > 0);
+        assertTrue(UploadPolicy.BLOCKED.compareTo(UploadPolicy.DISCOURAGED) > 0);
+        assertTrue(UploadPolicy.DISCOURAGED.compareTo(UploadPolicy.NORMAL) > 0);
+    }
 }