Changeset 13497 in josm for trunk/test/unit/org/openstreetmap/josm/data/osm/DataSetTest.java

Timestamp:

2018-03-04T15:18:05+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #16051, see #8039, see #10456 - more fixes for download/upload policies and locked status (merge of layers)

File:

• trunk/test/unit/org/openstreetmap/josm/data/osm/DataSetTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/data/osm/DataSetTest.java

@@ -3 +3 @@
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
@@ -14 +15 @@
 import org.junit.Test;
 import org.openstreetmap.josm.data.coor.LatLon;
+import org.openstreetmap.josm.data.osm.DataSet.DownloadPolicy;
 import org.openstreetmap.josm.data.osm.DataSet.UploadPolicy;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
@@ -194 +196 @@
     }
 
+    /**
+     * Unit test for {@link DataSet#mergeFrom} - Policies.
+     */
+    @Test
+    public void testMergePolicies() {
+        DataSet ds1 = new DataSet();
+        DataSet ds2 = new DataSet();
+
+        ds1.setUploadPolicy(UploadPolicy.BLOCKED);
+        ds2.setUploadPolicy(UploadPolicy.NORMAL);
+        ds1.mergeFrom(ds2);
+        assertEquals(UploadPolicy.BLOCKED, ds1.getUploadPolicy());
+
+        ds1.setUploadPolicy(UploadPolicy.NORMAL);
+        ds2.setUploadPolicy(UploadPolicy.BLOCKED);
+        ds1.mergeFrom(ds2);
+        assertEquals(UploadPolicy.BLOCKED, ds1.getUploadPolicy());
+
+        ds1.setDownloadPolicy(DownloadPolicy.BLOCKED);
+        ds2.setDownloadPolicy(DownloadPolicy.NORMAL);
+        ds1.mergeFrom(ds2);
+        assertEquals(DownloadPolicy.BLOCKED, ds1.getDownloadPolicy());
+
+        ds1.setDownloadPolicy(DownloadPolicy.NORMAL);
+        ds2.setDownloadPolicy(DownloadPolicy.BLOCKED);
+        ds1.mergeFrom(ds2);
+        assertEquals(DownloadPolicy.BLOCKED, ds1.getDownloadPolicy());
+
+        ds2.lock();
+        assertFalse(ds1.isLocked());
+        assertTrue(ds2.isLocked());
+        ds1.mergeFrom(ds2);
+        assertTrue(ds1.isLocked());
+    }
+
     private static void assertEqualsDataSet(DataSet ds1, DataSet ds2) {
         assertEquals(new ArrayList<>(ds1.getNodes()), new ArrayList<>(ds2.getNodes()));
@@ -202 +239 @@
         assertEquals(ds1.getVersion(), ds2.getVersion());
     }
+
+    /**
+     * Checks that enum values are defined in the correct order.
+     */
+    @Test
+    public void testEnumOrder() {
+        assertTrue(DownloadPolicy.BLOCKED.compareTo(DownloadPolicy.NORMAL) > 0);
+        assertTrue(UploadPolicy.BLOCKED.compareTo(UploadPolicy.NORMAL) > 0);
+        assertTrue(UploadPolicy.BLOCKED.compareTo(UploadPolicy.DISCOURAGED) > 0);
+        assertTrue(UploadPolicy.DISCOURAGED.compareTo(UploadPolicy.NORMAL) > 0);
+    }
 }