source: josm/trunk/data/validator/combinations.mapcss@ 15270

Last change on this file since 15270 was 15268, checked in by Klumbumbus, 6 years ago

fix #17973 - warn about Combined foot- and cycleway without segregated (except if surface is any kind of unpaved)

  • Property svn:eol-style set to native
File size: 29.3 KB
RevLine 
[6548]1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
[15268]5way[surface=~/^(unpaved|compacted|gravel|fine_gravel|pebblestone|ground|earth|dirt|grass|sand|mud|ice|salt|snow|woodchips)$/] { /* without grass_paver as it is controversial */
6 set unpaved_surface;
7}
8
[7229]9/* {0.key} without {1.key} (warning level) */
[7906]10way[junction ][!highway][junction!=yes],
[11407]11way[lanes ][!highway][leisure!=track][leisure!=swimming_pool],
[11305]12way[living_street ][!highway],
13way[maintenance ][!highway],
14way[median ][!highway],
15way[motorroad ][!highway],
16node[ntd_id ][!highway],
17way[sac_scale ][!highway],
18way[sidewalk ][!highway],
[13566]19way[step_count ][!highway][man_made!=tower],
[11305]20way[tracktype ][!highway],
[13092]21way[trail_visibility ][!highway], /* #15029 */
[11305]22way[trolley_wire ][!highway],
23way[zip_left ][!highway],
24way[zip_right ][!highway],
25way[detail ][!railway][route!=railway],
26way[eddy_current_brake ][!railway][route!=railway],
[13452]27way[electrified ][!railway][route!=railway][!highway], /* #16007 */
[11305]28way[etcs ][!railway][route!=railway],
29way[gauge ][!railway][route!=railway],
30way[grade_of_track ][!railway][route!=railway],
31way[kursbuchstrecke ][!railway][route!=railway],
32way[lzb ][!railway][route!=railway],
33way[old_railway_operator ][!railway][route!=railway],
34way[operating_procedure ][!railway][route!=railway],
35way[pzb ][!railway][route!=railway],
36way[structure_gauge ][!railway][route!=railway],
37way[tilting_technology ][!railway][route!=railway],
38way[track_class ][!railway][route!=railway],
39way[tracks ][!railway][route!=railway],
40way[traffic_mode ][!railway][route!=railway],
41way[workrules ][!railway][route!=railway],
42way[stream ][!waterway],
43way[length_unit ][!waterway],
44way[canal ][!waterway],
45way[have_riverbank ][!waterway],
[6548]46*[border_type ][!boundary],
[8121]47*[piste:difficulty ][!piste:type],
[14799]48*[place ][!name][place!=islet],
[15260]49*[transformer ][!power],
[6548]50*[source:date ][!source],
51*[source:name ][!name],
[13032]52*[source:maxspeed:forward ][!maxspeed:forward][!maxspeed],
53*[source:maxspeed:backward ][!maxspeed:backward][!maxspeed],
[6548]54*[source:building ][!building],
55*[source:ref ][!ref],
56*[source:population ][!population],
57*[source:postal_code ][!postal_code],
58*[source:ele ][!ele],
59*[source:ref:INSEE ][!ref:INSEE],
60*[source:lit ][!lit],
61*[source:hgv ][!hgv],
62*[source:highway ][!highway],
63*[source:maxaxleload ][!maxaxleload],
64*[source:surface ][!surface],
65*[source:bridge ][!bridge],
66*[source:old_name ][!old_name],
67*[source:bicycle ][!bicycle],
68*[source:designation ][!designation],
69*[source:height ][!height],
70*[source:lanes ][!lanes],
[6645]71*[source:postcode ][!addr:postcode],
72*[source:housenumber ][!addr:housenumber],
73*[source:addr:postcode ][!addr:postcode],
74*[source:addr:housenumber ][!addr:housenumber],
[6548]75*[source:addr ][!/^addr:/],
76*[source:maxspeed ][!/^maxspeed:?/] {
77 throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
[11146]78 group: tr("missing tag");
[6548]79 assertMatch: "way lanes=42";
80 assertNoMatch: "way lanes=42 highway=unclassified";
81 assertMatch: "node source:addr:postcode=postman";
82 assertMatch: "node source:addr=postman";
83 assertNoMatch: "node source:addr=postman addr:housenumber=42";
84}
85
[7229]86/* {0.key} without {1.key} (info level) */
[11305]87way[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
88way[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
[7229]89*[leaf_type ][!leaf_cycle],
90*[leaf_cycle][!leaf_type] {
91 throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
[11146]92 group: tr("missing tag");
[7229]93}
94
[15267]95/* {0.key} without {1.tag}, #17997 */
96*[generator:source ][power!=generator],
97*[generator:method ][power!=generator],
98*[generator:type ][power!=generator],
[14593]99node[fire_hydrant:type ][emergency!=fire_hydrant][disused:emergency!=fire_hydrant],
[15260]100node[manhole ][man_made!=manhole],
[11305]101way[fence_type ][barrier!=fence],
[6548]102*[recycling_type ][amenity!=recycling],
[7996]103*[information ][tourism!=information],
[11305]104node[board_type ][information!=board],
[6548]105*[shelter_type ][amenity!=shelter],
[11305]106node[lamp_type ][highway!=street_lamp],
107node[map_type ][information!=map],
[6548]108*[site_type ][historic!=archaeological_site],
[13508]109*[artwork_type ][tourism!=artwork][exhibit!=artwork],
[6548]110*[castle_type ][historic!=castle],
[8147]111*[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
[11305]112way[cutline ][man_made!=cutline],
[6548]113*[bunker_type ][military!=bunker] {
114 throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
[11146]115 group: tr("missing tag");
[6548]116}
117
[9903]118/* {0.key} without {1.tag} or {2.tag} */
[12677]119*[bridge:movable ][bridge!=movable][man_made!=bridge],
[9903]120*[substation ][power!=substation][pipeline!=substation],
[13972]121*[reservoir_type ][landuse!=reservoir][water!=reservoir],
122way[waterway=pressurised ][tunnel!=flooded][man_made!=pipeline] {
[9903]123 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
[11146]124 group: tr("missing tag");
[9903]125}
126
[8080]127/* {0.tag} without {1.key} (warning level) */
[15190]128node[traffic_sign=maxspeed][!maxspeed],
[15139]129node[actuator=manual][!handle],
[14593]130node[emergency=fire_hydrant][!fire_hydrant:type],
[14800]131way[ boundary=administrative][!admin_level],
[13084]132relation[boundary=administrative][!admin_level],
[14798]133relation[route=bicycle ][!network][type=route],
134relation[route=hiking ][!network][type=route],
135relation[route=foot ][!network][type=route],
136relation[route=horse ][!network][type=route],
[10320]137relation[route=piste][!piste:type][type=route],
[14798]138relation[route=ski ][!piste:type][type=route],
[7996]139*[tourism=information][!information],
[11153]140*[leisure=pitch][!sport],
[7929]141*[aeroway=terminal][!building],
[7967]142*[power=generator][!generator:source],
[11398]143*[amenity=social_facility][!social_facility],
[7929]144*[amenity=place_of_worship][!religion] {
[7923]145 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
[11146]146 group: tr("missing tag");
[7923]147}
148
[8080]149/* {0.tag} without {1.key} (info level) */
[11428]150way[highway=track ][!tracktype],
[9495]151way[power=cable ][!location],
[13814]152node[power=transformer ][!voltage:primary],
153node[power=transformer ][!voltage:secondary],
154node[transformer=distribution ][!voltage:primary][power=pole],
155node[transformer=distribution ][!voltage:secondary][power=pole],
[9500]156way[power=line ][!voltage],
157way[power=minor_line ][!voltage],
158way[power=cable ][!voltage],
159*[power=generator ][!voltage][generator:output:electricity],
160*[power=plant ][!voltage][plant:output:electricity],
161*[power=substation ][!substation],
[12997]162*[power=switch ][!switch],
[9500]163*[power=transformer ][!transformer],
[14799]164*[amenity=bank ][!operator],
165*[amenity=cinema ][!operator],
166*[amenity=fast_food ][!operator],
167*[amenity=fuel ][!operator],
168*[mountain_pass=yes ][!ele],
169*[natural=peak ][!ele],
[14818]170*[amenity=place_of_worship ][!denomination],
[8080]171*[amenity=parking ][!parking],
172*[amenity=parking_entrance ][!parking] {
173 throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
[11146]174 group: tr("missing tag");
[9500]175 assertMatch: "way power=line";
176 assertNoMatch: "way power=line voltage=1";
[12997]177 assertMatch: "way power=switch";
[9500]178 assertMatch: "way power=substation";
179 assertMatch: "way power=substation transformer=foobar";
180 assertNoMatch: "way power=substation substation=foobar";
181 assertMatch: "way power=generator generator:output:electricity=yes";
182 assertNoMatch: "way power=generator";
183 assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
[8080]184}
185
[6548]186/* {0.key} without {1.key} or {2.tag} */
[13026]187way[bridge:structure ][!bridge][man_made!=bridge],
[10068]188*[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking)$/],
[9003]189*[segregated ][!highway][railway!=crossing] {
[6548]190 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
[11146]191 group: tr("missing tag");
[6548]192}
193
[8746]194/* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
[11305]195way[highway=motorway][!oneway][junction!=roundabout],
196way[highway=motorway_link][!oneway][junction!=roundabout] {
[8591]197 throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
[11146]198 group: tr("missing tag");
[8545]199}
200
[13972]201/* {0.tag} without {1.tag} */
202way[usage=penstock][man_made!=pipeline],
203way[usage=penstock][waterway!=pressurised] {
204 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}");
205 group: tr("missing tag");
206}
207
[8411]208/* {0.tag} without {1.tag} or {2.tag} */
209*[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
210 throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
[11146]211 group: tr("missing tag");
[8411]212}
213
[8057]214/* {0.key} without {1.key}, {2.tag} or {3.tag} */
[14127]215*[intermittent ][!waterway][natural!~/^(water|spring)$/][landuse!~/^(basin|reservoir)$/][ford!=yes],
216*[boat ][!waterway][natural!=water ][landuse!~/^(basin|reservoir)$/][ford!=yes] {
217 throwWarning: tr("{0} without {1}, {2}, {3} or {4}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}", "{4.tag}");
[11146]218 group: tr("missing tag");
[7767]219}
220
[14735]221/* {0.key} without {1.key}, {2.key} or {3.key}, #17253 */
[15254]222way[oneway ][!highway][!railway][!aerialway][attraction!=summer_toboggan][aeroway!~/^(runway|taxiway)$/],
[14735]223*[snowplowing][!highway][!amenity][!leisure] {
[6880]224 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
[11146]225 group: tr("missing tag");
[6880]226}
227
[14735]228/* {0.key} without {1.key}, {2.key} or {3.tag}, #17255 */
229way[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/][attraction!=summer_toboggan],
[7250]230*[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
231 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
[11146]232 group: tr("missing tag");
[7250]233}
234
[15110]235/* {0.tag} together with {1.key}, see #17664, #17707, #16464, #10837, #14034, #9389, #11977, #13156, #16888 */
236*[power=plant][/^generator:/],
237*[power=generator][/^plant:/],
[15075]238*[power=plant][voltage],
239*[power=plant][frequency],
[14042]240*[internet_access=no][internet_access:fee],
[13814]241node[power=transformer][voltage],
242node[transformer=distribution][voltage][power=pole],
[11346]243*[amenity=vending_machine][shop],
[13401]244*[noname?][name],
[14364]245way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no],
246way[oneway=yes][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no],
247way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no],
248way[oneway=-1 ][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no] {
[8077]249 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
[11146]250 group: tr("suspicious tag combination");
[15110]251 assertMatch: "way power=plant generator:source=wind";
252 assertMatch: "way power=generator plant:source=combustion";
[8077]253}
254
[8044]255/* {0.tag} together with {1.tag} (info level), see #9696 */
[11305]256way[highway=footway][oneway=no] {
[8044]257 throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
[11146]258 group: tr("suspicious tag combination");
[8044]259}
260
[15094]261/* {0.tag} together with {1.tag}, see #17623, #17592, #17594, #17542, #16861, #16147, #10186 */
262way[junction=yes][highway],
[15268]263way[tracktype=grade1][surface].unpaved_surface,
[14987]264way[tracktype=grade2][surface][surface=~/^(sand|mud)$/],
[14356]265way[segregated][bicycle=no],
266way[segregated][foot=no],
[14041]267way[man_made=pipeline][tunnel=flooded],
[14943]268way[waterway=canal][tunnel=yes] {
[8117]269 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
[11146]270 group: tr("suspicious tag combination");
[8117]271}
272
[14808]273/* {0.tag} together with {1.tag} (error level) */
274relation[type=multipolygon][area=no] {
275 throwError: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
276 group: tr("suspicious tag combination");
277}
278
[15004]279/* {0.key} together with {1.key}, #17630, #17604 */
280*[building:part][building],
[15256]281*[addr:street][addr:place][outside("CZ,DK")] {
[14998]282 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
[13401]283 group: tr("suspicious tag combination");
284}
285
[11074]286/* #11127, #13727 */
287way[waterway][bridge=yes][waterway!=weir] {
[8089]288 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
289 suggestAlternative: "bridge=aqueduct";
[11146]290 group: tr("suspicious tag combination");
[8089]291 fixAdd: "bridge=aqueduct";
292}
[11074]293way[waterway=weir][bridge=yes][highway] {
294 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
295 suggestAlternative: "waterway=weir + ford=yes";
296 suggestAlternative: "waterway=dam";
297 suggestAlternative: tr("two objects, one with {0} and one with {1} + {2} + {3}", "{0.tag}", "{2.key}", "{1.tag}", "layer");
[11146]298 group: tr("suspicious tag combination");
[11074]299}
[8089]300
[13787]301/* #16214 */
302relation[type=multipolygon] >[role="inner"] way[area][eval(number_of_tags()) = 1] {
303 throwWarning: tr("{0} on an inner multipolygon ring without further tags", "{0.tag}");
304 fixRemove: "area";
305 set area_yes_autofix;
306 group: tr("suspicious tag combination");
307}
308
[12416]309/* only {0.key}, see #11104 #12422 #14950 */
310*[access][eval(number_of_tags()) = 1],
[13787]311*[area][eval(number_of_tags()) = 1]!.area_yes_autofix,
[8054]312*[name][eval(number_of_tags()) = 1],
[9837]313*[ref][eval(number_of_tags()) = 1],
314*[lit][eval(number_of_tags()) = 1] {
[8054]315 throwWarning: tr("incomplete object: only {0}", "{0.key}");
[11146]316 group: tr("missing tag");
[8054]317}
[13086]318/* only {0.key} and {1.key} */
[8054]319*[name][area][eval(number_of_tags()) = 2],
320*[name][ref][eval(number_of_tags()) = 2] {
321 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
[11146]322 group: tr("missing tag");
[8054]323}
[13086]324/* only {0.tag}, #15269 */
325*[tourism=attraction][eval(number_of_tags()) = 1] {
326 throwWarning: tr("incomplete object: only {0}", "{0.tag}");
327 group: tr("missing tag");
328}
329/* only {0.key} and {1.tag} */
330*[name][tourism=attraction][eval(number_of_tags()) = 2] {
331 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.tag}");
332 group: tr("missing tag");
333}
[8054]334
[11548]335/* #9811, #11491, #12865, #14310 */
336*[place][place!=farm][/^(addr:housenumber|addr:housename|addr:flats|addr:conscriptionnumber|addr:street|addr:place|addr:city|addr:country|addr:full|addr:hamlet|addr:suburb|addr:subdistrict|addr:district|addr:province|addr:state|addr:interpolation|addr:interpolation|addr:inclusion)$/],
337/* addr:postcode is used together with place in some countries */
[8043]338*[boundary][/^addr:/],
[8730]339*[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
[8043]340 throwWarning: tr("{0} together with addr:*", "{0.key}");
[11146]341 group: tr("suspicious tag combination");
[11548]342 assertMatch: "node place=foo addr:housenumber=5";
343 assertMatch: "node place=foo addr:housenumber=5 addr:postcode=12345";
344 assertNoMatch: "node place=foo addr:postcode=12345";
[8043]345}
[8730]346*[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
347 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
[11146]348 group: tr("suspicious tag combination");
[8730]349}
350*[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
351 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
[11146]352 group: tr("suspicious tag combination");
[8730]353}
354way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
355 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
[11146]356 group: tr("suspicious tag combination");
[8730]357 fixRemove: "addr:postcode";
358}
359way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
360 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
[11146]361 group: tr("suspicious tag combination");
[8730]362}
[10272]363way[highway][highway!=services][highway!=rest_area][!postal_code]["addr:postcode"] {
[11052]364 throwWarning: tr("{0} together with {1}", "{0.key}", "{4.key}");
[8730]365 suggestAlternative: "postal_code";
[11146]366 group: tr("suspicious tag combination");
[8730]367 fixChangeKey: "addr:postcode=>postal_code";
368}
[8043]369
[10350]370/* #9195 */
[11305]371way[highway=footway][cycleway=lane] {
[8042]372 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
[8046]373 suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
[11146]374 group: tr("suspicious tag combination");
[8042]375}
376
[6548]377/* {0} on suspicious object */
[14972]378*[tunnel ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing],
379*[bridge ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge][building!=bridge],
[14975]380*[psv ][!highway][!railway][!waterway][barrier!=bollard][amenity !~ /^parking.*/],
[14915]381*[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance][natural!=stone][leisure!=track],
[15194]382*[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:forward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:backward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming][aerialway!=zip_line] {
[6548]383 throwWarning: tr("{0} on suspicious object", "{0.key}");
[11146]384 group: tr("suspicious tag combination");
[6548]385}
386
[14798]387*[amenity][amenity =~ /^(restaurant|cafe|fast_food|pub|place_of_worship|school|university|hospital|library|theatre|courthouse|bank|cinema|pharmacy|fuel)$/][!name][noname!=yes] {
[11146]388 throwOther: tr("{0} without {1}", "{0.tag}", "{2.key}");
389 group: tr("missing tag");
[6548]390 assertMatch: "node amenity=restaurant";
[7932]391 assertNoMatch: "node amenity=restaurant noname=yes";
[6548]392 assertNoMatch: "node amenity=restaurant name=Foobar";
393}
394
[13645]395/* #10193, #16157 */
[6550]396way[highway][barrier],
[8559]397*[highway][waterway][waterway!=dam][waterway!=weir],
[11429]398way[highway][natural][natural!=ridge],
[14275]399*[landuse][building][landuse!=retail] {
[11146]400 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
401 group: tr("suspicious tag combination");
[13645]402 assertNoMatch: "node highway=street_lamp natural=birds_nest";
[6548]403}
404
[10350]405/* #6932 */
[10798]406*[natural=water][leisure=swimming_pool] {
[6548]407 throwWarning: tr("natural water used for swimming pool");
[11146]408 group: tr("suspicious tag combination");
[7274]409 fixRemove: "natural";
[6548]410}
[6860]411
[14735]412/* #9593, #11183, #12418, #12761, #17254 */
413*[sport][sport!=skiing][!building][!club][tourism != hotel][highway != raceway][!leisure][natural !~ /^(beach|bare_rock|cliff|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports][attraction!=summer_toboggan] {
[6860]414 throwWarning: tr("sport without physical feature");
[11146]415 group: tr("missing tag");
[6860]416 assertMatch: "node sport=tennis";
417 assertNoMatch: "node sport=tennis leisure=pitch";
418 assertNoMatch: "node sport=beachvolleyball natural=beach";
[11159]419 assertNoMatch: "node sport=skiing"; /* skiing has deprecated warning */
[6860]420 assertNoMatch: "node sport=swimming tourism=hotel";
421 assertNoMatch: "node sport=10pin amenity=restaurant";
[7243]422}
423
[13972]424/* {0.key} without {1.key} or {2.key} see #10140 */
425*[building:levels][!building][!building:part],
426way[usage][!railway][!waterway][route!=railway][man_made!=pipeline] {
[7243]427 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
[11146]428 group: tr("missing tag");
[7243]429}
[7488]430
[13981]431/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 #16437 */
432*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!lock_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
[7818]433 throwWarning: tr("alternative name without {0}", "{1.key}");
[11146]434 group: tr("missing tag");
[7818]435}
436
[10350]437/* #10837 */
[9386]438way[destination][!oneway?][junction!=roundabout][highway] {
[7818]439 throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
440 suggestAlternative: "destination:forward";
441 suggestAlternative: "destination:backward";
[8700]442}
443
[10350]444/* #11389 */
[8700]445way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
446 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
447 suggestAlternative: "maxspeed";
[11146]448 group: tr("suspicious tag combination");
[8700]449 fixChangeKey: "maxspeed:forward=>maxspeed";
450 fixRemove: "maxspeed:backward";
451}
452way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
453 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
454 set AllSameMaxspeed;
455 suggestAlternative: "maxspeed";
[11146]456 group: tr("suspicious tag combination");
[8700]457 fixRemove: "maxspeed:forward";
458 fixRemove: "maxspeed:backward";
459}
460way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
461 throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
[11146]462 group: tr("suspicious tag combination");
[8700]463}
464way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
465way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
466 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
[11146]467 group: tr("suspicious tag combination");
[8754]468}
469
[10350]470/* #11837 */
[8754]471way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
472way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
[11146]473 throwWarning: tr("{0} together with {1}", "{2.tag}", "{0.tag}");
474 group: tr("suspicious tag combination");
[10350]475}
476
477/* #12942 */
478relation[oneway][type!=route] {
479 throwWarning: tr("{0} on a relation without {1}", "{0.key}", "{1.tag}");
[10388]480}
481
482/* #9182 */
[10419]483way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) > 400] {
484 throwWarning: tr("Long waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
[11146]485 group: tr("suspicious tag combination");
[10388]486}
[10419]487way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) <= 400] {
488 throwOther: tr("Short waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
[11146]489 group: tr("suspicious tag combination");
[10537]490}
491
[13102]492/* #13144, #15536 */
493*[unisex=yes][female=yes][male!=yes][shop=hairdresser],
494*[unisex=yes][male=yes][female!=yes][shop=hairdresser] {
[10537]495 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
[11146]496 group: tr("suspicious tag combination");
[10537]497}
[13102]498*[unisex=yes][female=yes][male=yes][shop=hairdresser] {
[10537]499 throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}");
[11146]500 group: tr("suspicious tag combination");
[10537]501 fixRemove: "female";
502 fixRemove: "male";
503}
[13102]504*[female=yes][male=yes][!unisex][shop=hairdresser] {
[10537]505 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
506 suggestAlternative: "unisex=yes";
[11146]507 group: tr("suspicious tag combination");
[10537]508 fixRemove: "female";
509 fixRemove: "male";
510 fixAdd: "unisex=yes";
[10538]511}
512
[14883]513/* {1.key} without {2.tag} see #13138, #14468 */
514way!:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir], /* water=intermittent is deprecated and has an own warning */
515area:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir] {
[10538]516 throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
[11146]517 group: tr("missing tag");
[10538]518}
[10995]519
520/* see #8519, #11529, limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic */
521way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][turn:lanes ][tag(lanes)!=eval(count(split("|", tag("turn:lanes"))))],
522way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][change:lanes ][tag(lanes)!=eval(count(split("|", tag("change:lanes"))))],
523way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][maxspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("maxspeed:lanes"))))],
524way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][minspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("minspeed:lanes"))))],
525way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:lanes"))))],
526way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:ref:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:ref:lanes"))))],
527way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:symbol:lanes][tag(lanes)!=eval(count(split("|", tag("destination:symbol:lanes"))))] {
528 throwWarning: tr("Different number of lanes in the keys {0} and {1}", "{1.key}", "{2.key}");
[11146]529 group: tr("suspicious tag combination");
[11047]530}
531
532/* #13680 */
533area[golf=bunker][natural=beach] {
534 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
535 suggestAlternative: "natural=sand";
536 suggestAlternative: "surface=sand";
[11146]537 group: tr("suspicious tag combination");
[11080]538}
539
540/* #13705 */
541relation[type=multipolygon][building] > way {
542 set part_of_building_MP;
543}
544way["addr:housenumber"][!building][!"building:part"][!"demolished:building"][!note][!amenity][!leisure][!landuse][!man_made][!tourism][!barrier]!.part_of_building_MP {
545 /* don't exclude shop because a lot of real missing bulding tag cases have a shop tag. */
[11146]546 throwOther: tr("possibly missing {0} tag", "{1.key}");
547 group: tr("missing tag");
[11371]548}
549
[11529]550/* #14125, #14323 */
551way[highway][lanes][!lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1][junction!=roundabout][lanes>2][get(split(".", tag(lanes)/2), 1)=5] {
[11406]552 throwWarning: tr("street with odd number of {0}, but without {1} and {2} or {3}", "{1.key}", "{2.key}", "{3.key}", "{4.key}");
[11371]553 group: tr("missing tag");
554 assertNoMatch: "way highway=primary lanes=2";
555 assertNoMatch: "way highway=primary lanes=3 lanes:backward=2";
556 assertNoMatch: "way highway=primary lanes=3 oneway=-1";
[11406]557 assertNoMatch: "way highway=primary lanes=4";
[11371]558 assertMatch: "way highway=primary lanes=3";
[14593]559}
560
561/* #15774 */
562node[emergency=fire_hydrant][fire_hydrant:count][fire_hydrant:count!=1] {
563 throwOther: tr("{0} together with {1}. Tag each hydrant separately.", "{0.tag}", "{1.tag}");
[14798]564}
[14830]565
566/* #12502 */
567node[leisure=park][natural=tree] {
568 throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
569 group: tr("suspicious tag combination");
570 fixRemove: "leisure";
[14831]571}
572
573/* #17305 */
574area[boundary=administrative][landuse=residential] {
575 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
576 group: tr("suspicious tag combination");
577}
578
579/* #17391 */
[14910]580way[highway=pedestrian][width][width<3] {
[14831]581 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
582 suggestAlternative: "highway=footway";
583 group: tr("suspicious tag combination");
584 fixAdd: "highway=footway";
585 assertMatch: "way highway=pedestrian width=0.8";
586 assertMatch: "way highway=pedestrian width=1";
[14910]587 assertNoMatch: "way highway=pedestrian width=3";
[14831]588 assertNoMatch: "way highway=pedestrian width=5.5";
[15094]589}
590
591/* see #17623 */
[15131]592way:areaStyle[highway][highway =~ /motorway|trunk|primary|secondary|tertiary|unclassified|residential|service$|living_street|pedestrian|track|path|footway|cycleway|bus_guideway|bridleway/][area!=yes] {
[15094]593 throwOther: tr("A linear object {0} without {1} has a tag indicating that it is an area.", "{1.tag}", "{3.tag}");
594 group: tr("suspicious tag combination");
[15169]595}
596
597/* #17804 */
598area[cemetery=sector][landuse=cemetery] {
599 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
600 group: tr("suspicious tag combination");
[15265]601}
602
603/* #17967 */
604*[highway=cycleway][cycleway=track] {
605 throwWarning: tr("{0} together with {1}. Remove {1}.", "{0.tag}", "{1.tag}");
606 group: tr("suspicious tag combination");
607 fixRemove: "cycleway";
[15268]608}
609
610/* #17973 */
611way[highway=path ][foot][foot!=no ][!segregated][bicycle][bicycle!=no]!.unpaved_surface,
612way[highway=footway ][bicycle][bicycle!=no][!segregated]!.unpaved_surface,
613way[highway=cycleway][foot][foot!=no ][!segregated]!.unpaved_surface {
614 throwWarning: tr("Combined foot- and cycleway without {1}.", "{3.key}");
615 group: tr("missing tag");
[14830]616}
Note: See TracBrowser for help on using the repository browser.