Modify

Opened 15 months ago

Closed 13 months ago

Last modified 13 months ago

#7463 closed defect (fixed)

new download/upload shortcuts don't work if the properties window is active

Reported by: NE2 Owned by: team
Priority: normal Component: Core
Version: Keywords:
Cc:

Description

After clicking in the properties/memberships window, hitting ctrl-shift-down does not download, but instead expands the selection. I've already come across this several times, since I use download to see where I am.

Attachments (0)

Change History (11)

comment:1 Changed 15 months ago by akks

Please reopen the ticket if problem persists - I tried to use some hack :)

comment:2 follow-up: Changed 15 months ago by akks

  • Resolution set to fixed
  • Status changed from new to closed

In 5032/josm:

fix #7463: Ctrl-Shift-Up/Down shortcuts did't work if the properties window is active

comment:3 in reply to: ↑ 2 Changed 15 months ago by NE2

Most likely what you did now breaks existing shortcuts in the properties window. The aim of the change was to get rid of shortcut conflicts, but this one didn't.

comment:4 Changed 15 months ago by akks

Ctrl-Shift-Up/Down for tables are some standard Swing (not JOSM) shortcuts that no one use. Half of other Properties windows shortcut was added by me, so I would notice it.

  1. S. I forgot to do the same with membershipTable ...

comment:5 Changed 15 months ago by NE2

It also happens in the layers window, and perhaps elsewhere. I don't know if your fix takes care of this (5032 isn't available yet).

comment:6 Changed 15 months ago by akks

It seems it does not happen in 5032 for layers and relation members list without additional patching. When you are in selection list, changes list and validator dialog, Ctrl-Shift-Up/down does not work for upload/download, but this seems OK, as they loose focus when clicking on the map.

comment:7 Changed 13 months ago by NE2

  • Resolution fixed deleted
  • Status changed from closed to reopened

This still happens in some windows such as relations. Reopening.

comment:8 Changed 13 months ago by akks

Is this a problem: When you select one relation in relation list (toggle dialog), Ctrl-Shift-Up/Down works for selecting, not downloading ?

Please specify all other places where this does happen.

comment:9 Changed 13 months ago by NE2

Yes, it happens if you click in selection, relations, and probably other panes I don't usually have open.

comment:10 Changed 13 months ago by akks

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5200/josm:

see #7626, fix #7463: keys Ctrl-Shift-Up/Down, Enter, Spacebar work better in toggle dialogs
Enter and Spacebar = useful actions for list items (select, toggle, etc.)

comment:11 Changed 13 months ago by akks

Please check if the behavior improve and see #7626 for other changes.

Compiled jar 5200: http://dl.dropbox.com/u/63393258/josm-custom.jar

Last edited 13 months ago by akks (previous) (diff)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.