Modify

#6907 closed defect (fixed)

[Patch needs rework] Error reading audio files from case sensitive filesystem

Reported by: mdk Owned by: OliverW
Priority: normal Component: Plugin columbuscsv
Version: latest Keywords:
Cc: dk31519

Description (last modified by mdk)

When I read a Columbus CSV file from the SD-card (formatted with FAT16) I also get the audio files. But when I try to read them from my disk archive (ext4), I did't get the files. Instead there are errors like:

Open file: /home/michael/src/osm/ColumbusData/11092800.CSV (114175 bytes)
File vox00043 not found!
Fehlende Audiodatei: vox00043

The problem is, that ext4 is case sensitive and the files are named

VOX00043.WAV

and not

vox00043.wav

The reason for this is in ColumbusCSVReader.java line 366

if (isExtMode) {

voxFile = csvLine[14].toLowerCase();

} else {

voxFile = csvLine[9].toLowerCase();

}

Why is there a ".toLowerCase()"?

Attachments (1)

patch_6907.diff (1.1 KB) - added by mdk 20 months ago.
Final patch for this bug.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 20 months ago by anonymous

Ticket #6908 has been marked as a duplicate of this ticket.

comment:2 Changed 20 months ago by skyper

Ticket #5227 has been marked as a duplicate of this ticket.

comment:3 Changed 20 months ago by skyper

  • Cc dk31519 added

comment:4 Changed 20 months ago by OliverW

Fixed in 26819.

comment:5 Changed 20 months ago by OliverW

  • Resolution set to fixed
  • Status changed from new to closed

Changed 20 months ago by mdk

Final patch for this bug.

comment:6 Changed 20 months ago by mdk

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Error reading audio files from case sensitive filesystem to [Patch] Error reading audio files from case sensitive filesystem

You are on the right way by checking different cases for the filename, but you add always ".wav" in lover case.

comment:7 Changed 19 months ago by bastiK

for reference: see [o26819] and [o26828].

comment:8 Changed 19 months ago by bastiK

@mdk: Please update your patch, it doesn't apply.

Could you attach a sample columbus csv file that we can keep in the repository for testing?

comment:9 Changed 19 months ago by bastiK

  • Summary changed from [Patch] Error reading audio files from case sensitive filesystem to [Patch need rework] Error reading audio files from case sensitive filesystem

comment:10 Changed 19 months ago by bastiK

  • Summary changed from [Patch need rework] Error reading audio files from case sensitive filesystem to [Patch needs rework] Error reading audio files from case sensitive filesystem

comment:11 Changed 19 months ago by OliverW

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.