Warn for old-style WMS URLs

[eyewitness]

Since Version 1815 the WMS Layer does not show the downloaded images. I've tried it with older josm versions, and they are doing it well. I also tried it with different WMS, same behavior. There is no red error image, or message in the command line. A local WMS proxy in front of josm, says also that the data is delivered well. So i assume, that it could be a problem with graphics.

Another effect, occurred some days ago, i had to adapt my WMS connection strings, to be sure they are ending with the ampersand (&). May be, a check was skipped, and should be reimplemented, before adding the bbox and with/height parameters to the connection string.

os: debian sid; amd64
java: sun-java 6.14

Cheers eyewitness

[stoecker]

I rebuild wmsplugin which fixed the issue.

[eyewitness]

Yes, I can confirm, that after an update of the WMS plugin the WMS layer is back again. Thx a lot. :-)

I know, it's not good to mention 2 problems in one bug report. So I leave this one closed. But should I open an additional report regarding the now mandatory ampersand at the end of the WMS connection string? Or is these new behavior intended? Without the ampersand at the end, josm adds the bbox parameter right at the end of the user defined connection string, not checking whether there is an separating ampersand in front rather at the end of the user-defined string. So if the user string defines some WMS parameters, the request will fail, 'cause the bbox parameter is not recognized by the WMS.

Cheers Andreas

[stoecker]

Well, I removed the heuristic from WMS code to allow better support of different URLs. Maybe I should add some warning when uncommon URLs are found at least until all URL's are converted?

But how. Warning each time josm is started will be very disturbing. Maybe a DontShowMeAgain warning is a good idea.

[anonymous]

Okay, I understand.
However, there shouldn't be so much people adding custom WMS to josm. So a hint like "Remember to suffix your custom WMS string with an ampersand, when passing own parameters!" in WMS preferences, should do the job meanwhile. :-)

Thx again

Cheers Andreas

[Gubaer]

Fixed in recent version of WMS plugin, [o17407] and higher.