Ticket #2387 (closed defect: fixed)
oneway=no shown with arrow
| Reported by: | smsm1 | Owned by: | ulfl |
|---|---|---|---|
| Priority: | major | Component: | Internal mappaint style |
| Version: | Keywords: | ||
| Cc: | unriccio@…, kay@…, nakor.wp@… |
Description
It seems that oneway=no is shown as though it is a one way road, which isn't true and can be confusing when editing.
Attachments
Change History
comment:1 Changed 3 years ago by stoecker
- Status changed from new to closed
- Resolution set to wontfix
comment:2 Changed 2 years ago by unriccio@…
- Cc unriccio@… added
- Status changed from closed to reopened
- Resolution wontfix deleted
that's wrong because all "_link" ways imply oneway=yes, and one have to explicitly tag the oneway=no ways: http://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway_link
comment:3 Changed 2 years ago by ramzai
JOSM only cares for the key itself and not its value for speed reasons.
Also there is oneway=-1, that reverses direction and that makes such oneways to be shown in the wrong direction in JOSM.
comment:4 Changed 2 years ago by jttt
Performance is no longer an issue because JOSM now keeps hasDirectionKeys as flag that is recalculated only when primitive keys are changed. It should be even possible (fast enough) to use pattern from Search action to decide whether arrow should be shown
Changed 2 years ago by anonymous
-
attachment
oneway.png
added
used oneway values - rendering with josm 2466
comment:5 Changed 2 years ago by kay_D
- Cc kay@… added
What happens with the direction of the way, can it still be seen? I use :left and :right a lot and they depend on the direction. If (for oneway=-1) the arrows are reversed visually, I see potential for tagging errors.
comment:8 Changed 2 years ago by jttt
Ways with oneway=no no longer have arrows, oneway=-1 is still broken.
What should we do with _link highways? Show arrows unless oneway=no?
Currently the search pattern to identify ways is arrows is as follows: oneway? | incline=* | incline_steep=* | aerialway=* | waterway=stream | waterway=river | waterway=canal | waterway=drain | "piste:type"=downhill | "piste:type"=sled | man_made="piste:halfpipe"
comment:10 follow-up: ↓ 12 Changed 2 years ago by bastiK
I like to add incline=-10% (some negative value) to the reversed arrow search pattern. Currently I don't know how. (Maybe regex?)
comment:11 Changed 2 years ago by augustus.kling@…
I suggest not showing arrows for “_link” highways at the moment because the implicated tags are unclear. Different languages of the OSM wiki are stating contradictory implications.
The implied tags for “highway=motorway_link” from the wiki:
German: oneway=yes
English: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Italian: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Russian: oneway=yes, access=no, motorcar=yes, hgv=yes, surface=paved
Ukrainian: oneway=yes
I am aware of the fact that oneway=yes is given in all cases for highway=motorway_link. However for highway=trunk_link, highway=primary_link or highway=secondary_link this is not implicated in all languages. Instead oneway=* is mentioned.
I suggest, cleaning up the wiki first so that it only implies oneway=yes for all “_link” highways. After that was done, arrows should be shown for “_link” highways unless oneway=no is given.
In my opinion guessing vehicle type restrictions or surfaces should be left to the routers/renders and not be implied globally as implications may differ across regions. Clearly, implying access=no makes no sense but JOSM's bug tracker is not the right place for tagging scheme discussions.
comment:12 in reply to: ↑ 10 Changed 2 years ago by jttt
Replying to bastiK:
I like to add incline=-10% (some negative value) to the reversed arrow search pattern. Currently I don't know how. (Maybe regex?)
I think you can't currently do that. Search expression should get some way to mark that pattern is regular expression or case insensitive, without using checkboxs..
comment:13 Changed 8 months ago by skyper
- Status changed from reopened to closed
- Resolution set to fixed
The main issue of the ticket is fixed (oneway <-> arrows).
The incline problem should go into another ticket.
Note: I think it is dangerous to render oneway and incline with on function. What do you do with a oneway road leading downhill ?



Yes. JOSM only cares for the key itself and not its value for speed reasons. Anyway this is no big issue as oneway=no is default, so it needs not be entered at all.