Deprecate car in favor of motorcar

[Famlam]

What steps will reproduce the problem?

1. Validate a way or node with car=yes (​example)

What is the expected result?

Validation warning. car is ​deprecated in favor of motorcar

What happens instead?

No warning, unless it's on a amenity=charging_station

Please provide any additional information below. Attach a screenshot if possible.

Perhaps remove the restriction to charging stations from deprecated.mapcss.
To my knowledge, car=* is deprecated completely (not just for amenity=charging_stations) and according to TagInfo over 2k ways are still using it

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-29 02:30:53
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 792 MB / 1820 MB (655 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32

Plugins:
+ OpeningHoursEditor (35640)
+ SimplifyArea (35640)
+ imagery_offset_db (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35688)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ undelete (35640)
+ utilsplugin2 (35691)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

[Famlam]

P.s. is it useful (in general, not only for this particular issue) if I create a PR on Github? That's much easier than doing it here, but I don't know if that also works for you?

[taylor.smock]

It depends upon who looks at the patch. I'm OK with looking at PRs on GitHub.

Regardless, please make certain that a ticket on JOSM Trac (this site) has a link to the PR, and the title of the ticket has PATCH in it.

[Klumbumbus]

For such minimal changes a patch is not really needed. The "major work" is to check if the request of the ticket is valid.

[Klumbumbus]

In 18644/josm:

fix #20539, see #18659, see #18719 - Deprecate car in favor for motorcar also for non charging stations

[Famlam]

Thanks! It's fairly easy for me to create a Github PR, while in issues like #21722 I refer to

(or add the selectors here: https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L283 )

where the line number gets outdated very quickly, hence I figured a Github PR would add value in these cases