Modify

Opened 4 years ago

Closed 4 years ago

#1943 closed enhancement (fixed)

[PATCH] Separate Download and file GPX layers

Reported by: raffourtit@… Owned by: framm
Priority: minor Component: Core
Version: tested Keywords: gpx
Cc:

Description

using josm 1198

When raw gps data is downloaded it merges into the layer containing a user loaded gpx file. This makes it impossible to see only the user gpx file.

Steps to reproduce

  • Start JOSM
  • open a local .gpx file for editing (call it foo.gpx)
  • download OSM data (select both 'openstreetmap data' and 'Raw GPS Data')
  • Setting layer foo.gpx invisible also hides the raw gps points. There is no way to hide the raw GPS points and still show foo.gpx.

As a workaround: Use File, Open, foo.gpx again. Then another layer is created.

Attachments (2)

Server GPX data to new layer.patch (1.6 KB) - added by xeen 4 years ago.
Server GPX data to new layer AND fixing bug 1872.patch (1.7 KB) - added by xeen 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by stoecker

  • Summary changed from Downloaded gpx data layer merges with user gpx layer to Separate Download and file GPX layers
  • Type changed from defect to enhancement

comment:2 Changed 4 years ago by xeen

You can check the "create new layer", too. Currently this is by design, but we probably don't want to merge downloaded and local GPX data, at least I've never found it useful. Might make fixing #1872 easier, too.

comment:3 Changed 4 years ago by xeen

  • Summary changed from Separate Download and file GPX layers to [PATCH] Separate Download and file GPX layers

That was actually pretty easy. It looks for download.gps.mergeWithLocal (default: false) and then decides whether two layers can be merged using layer.data.fromServer.

Changed 4 years ago by xeen

comment:4 Changed 4 years ago by xeen

The latter patch uses a che ap but effective fix and simply names all downloaded GPX layers "Downloaded GPX data" and thereby enables users to set a default style using common means without making the options dialog overly complicated.

This has the disadvantage though of downloaded GPX layers being named the same. At least for this was never an issue, I didn't get much from the coordinates and found out which I wanted by showing/hiding them.

comment:5 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Applied in r1396.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.