Modify

Opened 4 years ago

Closed 4 years ago

#1872 closed enhancement (fixed)

[patch] Offer two "Draw lines between raw GPS points" preferences depending on whether the data comes from OSM or not

Reported by: avar Owned by: framm
Priority: minor Component: Core
Version: latest Keywords:
Cc:

Description

In Preferences -> Display settings -> GPS points there's a sub-setting to "Draw lines between raw GPS points" which enables the user to select the maximum distance between two points so that lines should be drawn between them.

This is useful when downloading GPS tracks from OSM as they don't contain enough information to distinguish multiple tracks, however when working with local GPX tracks which have no ambiguity as to what sequence points are in and which of many GPX tracks they belong one ends up setting the value to -1, only to set it to say 500 to use OSM GPS data again.

The preference should be split into two, one value which applies to normal GPX data and one value to apply to OSM GPX data.

Attachments (5)

JOSM-50m.png (24.1 KB) - added by avar 4 years ago.
Maximum length set to 50 and draw lines for All points
JOSM-200m.png (33.4 KB) - added by avar 4 years ago.
Maximum length set to 200 and draw lines for All points
JOSM-200m-and-Custom.png (19.7 KB) - added by avar 4 years ago.
Maximum length set to 200 and draw lines for All points, but with custom settings for the downloaded layer
drawRawGpsMaxLineLengthLocal.patch (4.3 KB) - added by avar 4 years ago.
Adds a new field to "GPS points" preferences for maximum length line drawing for local files
drawRawGpsMaxLineLengthLocal-200m.patch (4.6 KB) - added by avar 4 years ago.
Same patch, but set "Maximum length" for non-local files to a default of 200 meters

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by anonymous

  • Type changed from defect to enhancement

comment:2 follow-up: Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

In r1396 the server layer now has an undividual name. Settings can be applied to that name via right click on layer name.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 4 years ago by avar

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to anonymous:

In r1396 the server layer now has an undividual name. Settings can be applied to that name via right click on layer name.

No, being able to bring up the "Customize line drawing" dialog for downloaded GPS points from the API doesn't help with this issue, so I'm reopening it.

I initially initially reported this issue because there's no way to have separate "Maximum length (meters)" for local data - which (usually) contains track and trackpoint informations - and GPS data downloaded from the API, which only has trackpoint information. This is still the case today.

I'm attaching two screenshots which demonstrate this issue. The red dots/lines are a local GPX file and blue dots/lines is downloaded GPX data from the API.

  • JOSM-50m.png
  • JOSM-200m.png

Here I've set "Draw lines between raw GPS points" to "All". Setting "Maximum length" to 50 works well for the API data in this case, but not for my local data as my GPS isn't logging that frequently. Setting "Maximum length" to 200 works better for the local data, but the downloaded data suffers.

  • JOSM-200m-and-Custom.png

Here I'm using "Customize line drawing" to not draw lines for the downloaded data as you suggest, but this is not what I want, I want to draw lines between the downloaded data points too. But I want to use different Maximum length values for Local and Remote data.

Changed 4 years ago by avar

Maximum length set to 50 and draw lines for All points

Changed 4 years ago by avar

Maximum length set to 200 and draw lines for All points

Changed 4 years ago by avar

Maximum length set to 200 and draw lines for All points, but with custom settings for the downloaded layer

comment:4 in reply to: ↑ 3 Changed 4 years ago by avar

Replying to avar:

I initially initially reported this issue because there's no way to have separate "Maximum length (meters)" for local data - which (usually) contains track and trackpoint informations - and GPS data downloaded from the API, which only has trackpoint information.

The attached patch implements this.

Changed 4 years ago by avar

Adds a new field to "GPS points" preferences for maximum length line drawing for local files

comment:5 Changed 4 years ago by stoecker

  • Summary changed from Offer two "Draw lines between raw GPS points" preferences depending on whether the data comes from OSM or not to [patch] Offer two "Draw lines between raw GPS points" preferences depending on whether the data comes from OSM or not

Changed 4 years ago by avar

Same patch, but set "Maximum length" for non-local files to a default of 200 meters

comment:6 Changed 4 years ago by avar

I've attached attachment:drawRawGpsMaxLineLengthLocal-200m.patch as an alternate patch. It changes the default line drawing length for "All" files to 200 meters while leaving the default for local files at -1.

This will probably make things less confusing for newbies that turn on line drawing and download GPS data from the API as straight lines won't be drawn criss-cross across the map view in most cases.

comment:7 Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from reopened to closed

In r1577.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.