Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1627 closed defect (fixed)

[PATCH] Bugfix for plugin activation

Reported by: egore911@… Owned by: framm
Priority: trivial Component: unspecified
Version: latest Keywords:
Cc:

Description

I updated a plugin recently and I had issues when it was activated. I'm not sure if this is because of java 1.6 but File.delete() returns false if the file does not exist. But this is the case if the plugin is installed at a different place before the update. I.e. Gentoo installs all plugins to /usr/lib/josm/plugins/ and loads them from there. But updating the plugins will put them to %HOME%/.josm/plugins. And calling delete on the %HOME%/.josm/plugins file will not work. The attached patch works around that. It also verifies that the user is allowed to activate the plugins (has write-capability).

Attachments (1)

josm-plugin-activation.java​ (1.1 KB) - added by egore911@… 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by egore911@…

comment:1 Changed 5 years ago by anonymous

  • Component changed from Core to unspecified
  • Priority changed from major to trivial
  • Summary changed from Bugfix for plugin activation to [PATCH] Bugfix for plugin activation

actually this seems to be a workaround for broken installations

comment:2 Changed 5 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in #1017.

comment:3 Changed 5 years ago by anonymous

Aehm r1017 :-)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.