Changeset 1017 in josm

Timestamp:

Oct 5, 2008 12:46:09 PM (5 years ago)

Author:

stoecker

Message:

close bug #1627

File:

• trunk/src/org/openstreetmap/josm/plugins/PluginDownloader.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginDownloader.java

@@ -173 +173 @@
                 File pluginDir = Main.pref.getPluginsDirFile();
                 boolean ok = true;              
-                if (pluginDir.exists() && pluginDir.isDirectory()) {
+                if (pluginDir.exists() && pluginDir.isDirectory() && pluginDir.canWrite()) {
                         final File[] files = pluginDir.listFiles(new FilenameFilter() {
                                 public boolean accept(File dir, String name) {
@@ -181 +181 @@
                                 final String filePath = updatedPlugin.getPath();
                                 File plugin = new File(filePath.substring(0, filePath.length() - 4));
-                                ok = plugin.delete() && updatedPlugin.renameTo(plugin) && ok;
+                                ok = (plugin.delete() || !plugin.exists()) && updatedPlugin.renameTo(plugin) && ok;
                         }
                 }