Modify

Opened 3 weeks ago

Closed 3 weeks ago

#15701 closed enhancement (fixed)

[PATCH] CorrelateGpxWithImages: Test newGpsData, speed, elevation, gpsTime set by matchGpxTrack()

Reported by: holgermappt Owned by: team
Priority: minor Milestone: 17.12
Component: Core image mapping Version: latest
Keywords: Cc:

Description

This relates to comment:5:ticket:15506. The patch adds tests for the four fields that are not checked in CorrelateGpxWithImagesTest so far:

  • isNewGpsData
  • speed
  • elevation
  • gpsTime

The test revealed that ImageEntry.hasNewGpsData() doesn't consider tmp, so it now tests for tmp to be in line with methods like getPos(), getSpeed(), and getGpsTime().

Two <speed/> tags were added to the GPX track to check the speed handling (speed is always calculated and not taken from the GPX).

Attachments (1)

CorrelateGpxWithImages_newSpeedEle.patch (4.9 KB) - added by holgermappt 3 weeks ago.
Patch file.

Download all attachments as: .zip

Change History (3)

Changed 3 weeks ago by holgermappt

Patch file.

comment:1 Changed 3 weeks ago by Don-vip

Milestone: 17.12

comment:2 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 13256/josm:

fix #15701 - CorrelateGpxWithImages: Test newGpsData, speed, elevation, gpsTime set by matchGpxTrack() (patch by holgermappt)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.