Changes between Version 33 and Version 98 of ImageryCompare


Ignore:
Timestamp:
(multiple changes)
Author:
(multiple changes)
Comment:
(multiple changes)

Legend:

Unmodified
Added
Removed
Modified

  • ImageryCompare

    v33 v98  
    11[[TranslatedPages]]
    2 = Comparison between ​[[https://github.com/osmlab/editor-imagery-index|GitHub project Editor Layer Index]] (former Editor Imagery Index) and [[wiki:Maps|JOSM]] imagery lists.
     2[[PageOutline(2-4,Table of Contents)]]
     3= Comparison between ​ELI and JOSM imagery lists =
     4== Documentation==
     5This page compares the imagery lists of the [https://github.com/osmlab/editor-imagery-index GitHub project Editor Layer Index] (former Editor Imagery Index) and [wikitr:/Maps JOSM] to find differences or problems with imageries. The following table explains what the different colors in the output below mean. If a red line can't be resolved it can be added to the [ImageryCompareIgnores ignore list]. There is also a more detailed reason for each ignore entry documented.
    36
    4 ||= color =||= description =||= action =||
    5 || [[span(style=color: black, black)]] || [[span(style=color: black, informational texts)]] ||  ||
    6 || [[span(style=color: red, red)]] || [[span(style=color: red, entries in ELI but not in JOSM)]] || [[span(style=color: red, should be checked)]] ||
    7 || [[span(style=color: red, red)]] || [[span(style=color: red, JOSM shape problems)]] || [[span(style=color: red, should be checked)]] ||
    8 || [[span(style=color: red, red)]] || [[span(style=color: red, differences between ELI and JOSM)]] || [[span(style=color: red, should be checked)]] ||
    9 || [[span(style=color: blue, blue)]] || [[span(style=color: blue, entries in JOSM but not in ELI)]] || [[span(style=color: blue, should be checked)]] ||
    10 || [[span(style=color: blue, blue)]] || [[span(style=color: blue, ELI shape problems)]] || [[span(style=color: blue, should be checked)]] ||
    11 || [[span(style=color: green, green)]] || [[span(style=color: green, entries which have been checked and are on ignore list (only minor style differences))]] || [[span(style=color: green, can be fixed but is not really necessary)]] ||
    12 || [[span(style=color: DarkGoldenrod, yellow)]] || [[span(style=color: DarkGoldenrod, entries which have been checked and are on ignore list (outdated in ELI))]] || [[span(style=color: DarkGoldenrod, should be fixed in ELI)]] ||
    13 || [[span(style=color: red, red)]] || [[span(style=color: red, +++ Obsolete skip entry: at the end of this list flags old entries of the ignore list, which are no longer applicable)]] || [[span(style=color: red, should be removed from the ignore list)]] ||
     7||= **Color** =||= **Description** =||= **Action** =||
     8||  [[span(style=color: black, black)]]  || [[span(style=color: black, informational texts)]] ||  ||
     9||  [[span(style=color: brown, brown)]]  || [[span(style=color: brown, entries in ELI but not in JOSM)]] || [[span(style=color: brown, should be checked and fixed or added to ignore list)]] ||
     10||  [[span(style=color: red, red)]]  || [[span(style=color: red, problems with JOSM entries)]] || [[span(style=color: red, should be checked and fixed)]] ||
     11||  [[span(style=color: brown, brown)]]  || [[span(style=color: brown, differences between ELI and JOSM)]] || [[span(style=color: brown, should be checked and fixed or added to ignore list)]] ||
     12||  [[span(style=color: blue, blue)]]  || [[span(style=color: blue, entries in JOSM but not in ELI)]] || [[span(style=color: blue, should be checked)]] ||
     13||  [[span(style=color: blue, blue)]]  || [[span(style=color: blue, problems with ELI entries)]] || [[span(style=color: blue, should be checked and fixed in ELI or added to ignore list)]] ||
     14||  [[span(style=color: green, green)]]  || [[span(style=color: green, entries which already have been checked and are on the ignore list (e.g. only minor style differences, or sync impossible))]] || [[span(style=color: green, no action required)]] ||
     15||  [[span(style=color: DarkGoldenrod, golden)]]  || [[span(style=color: DarkGoldenrod, entries which already have been checked and are on the ignore list (outdated in ELI))]] || [[span(style=color: DarkGoldenrod, should be fixed in ELI)]] ||
     16||  [[span(style=color: indigo, purple)]]  || [[span(style=color: indigo, different ids)]] || [[span(style=color: indigo, not yet decided how to proceed, see [ticket:14655#comment:60])]] ||
     17||  [[span(style=color: orange, yellow)]]  || [[span(style=color: orange, new checks in test phase)]] || [[span(style=color: orange, should be checked and fixed if applicable)]] ||
     18||  [[span(style=color: brown, brown)]]  || [[span(style=color: brown, +++ Obsolete skip entry: at the end of this list flags old entries of the ignore list, which are no longer applicable)]] || [[span(style=color: brown, should be removed from the ignore list)]] ||
    1419
    15 The ignore list is maintained at ImageryCompareIgnores. There is also a more detailed reason for each ignore entry documented.
    16 
    17 Note that it is possible that there are yellow or blue entries (ELI problems) which are already fixed there in the sources, but not yet pushed to the combined result file imagery.geojson.
    18 
    19 This [source:josm/trunk/scripts/SyncEditorLayerIndex.groovy script] compares the following properties:
     20This [source:josm/trunk/scripts/SyncEditorLayerIndex.java script] compares the following properties:
    2021* source URL
    2122* type (WMS/TMS/WMTS)
    … …  
    2324* min_zoom and max_zoom
    2425* country code
    25 * shapes
    26 * icon
     26* shapes (coordinates are rounded to 5 decimal digits for the comparison process)
     27* icon (ELI [https://github.com/osmlab/editor-layer-index/commit/9745988dcd177e4d4c32b41e715a7abe6a10c61e "unembedded"] icons, which were stored as data URL before, so these icons are no longer comparable by the script.)
    2728* best
    2829* date
    29 
    30 This script does '''not''' compare everything else like:
    31 * id
    32 * copyright/attribution information
     30* copyright/attribution information (permission-ref and terms-of-use-url (JOSM) both map to license_url (ELI))
    3331* projections
    3432* description
    35 * ...
     33* id
     34* default
     35* overlay
     36* no-tile-header
     37* category
     38* privacy-policy-url
    3639
    37 The compared files are https://josm.openstreetmap.de/maps and https://github.com/osmlab/editor-layer-index/raw/gh-pages/imagery.geojson.
     40This script first tries to find matching URLs and in the remaining data it tries to find matching IDs. Everything left will be reported.
     41The script does not compare all special properties which are available in only one of the two databases.
    3842
    39 **New data may be delayed up to half an hour! ** (But it is usually much faster.)
     43ELI-only properties according to [https://github.com/osmlab/editor-layer-index/blob/gh-pages/schema.json ELI-schema] are:
     44* i18n (see #18684)
     45* permission_osm
    4046
    41 = Results
     47JOSM-only properties according to [wiki:/Maps#Documentation JOSM-schema] are:
     48
     49* logo-url
     50* mirror
     51
     52The script also does not yet compare the following properties as they are not yet actively used in ELI:
     53
     54* eula
     55* logo-image
     56* terms-of-use-text
     57* no-tile-checksum
     58* metadata-header
     59* valid-georeference
     60* tile-size
     61* mod-tile-features
     62* custom-http-headers
     63* default-layers
     64* format
     65* transparent
     66* minimum-tile-expire
     67
     68For entries of the kind "... differs ('aaa' != 'bbb')", the first variant (aaa) is ELI and the second (bbb) JOSM.
     69
     70The files actually used for the comparison are [/maps maps] and [https://github.com/osmlab/editor-layer-index/raw/gh-pages/imagery.geojson imagery.geojson].
     71
     72For easier syncing between JOSM and ELI there are two features:
     73* [/maps?format=geojson&pretty=true This] file displays the JOSM database in ELIs geojson format. Note that this file may contain JOSM-only properties (see above) which are not (yet) supported by the ELI schema. Possibly you need to remove these properties when syncing to ELI. Also note that terms-of-use-url isn't converted to license_url in the geojson output.
     74* The command `ant dist imageryindexdownload` in the JOSM svn repository produces several files including `imagery_eliout.imagery.xml` which is the ELI database in JOSMs xml format. (ELI has an XML output too, but it is without the indentation JOSM uses in the wiki, which makes syncing hard.)
     75* The file [/mapseli] contains the `imagery_eliout.imagery.xml` contents and can be used for Copy&Paste of new entries.
     76
     77New data is usually taken into account within a few seconds after a JOSM wiki edit or the ELI traviscibot completed his work. (You need to reload this page then to update the comparison script.)
     78
     79== Results ==
     80Current number of entries for each type: [[ImageryCompare(stats)]]
     81
     82See [#OnlyErrors below] for the summary of all new, unresolved issues.
    4283
    4384[[ImageryCompare]]
     85
     86== Only Errors == #OnlyErrors
     87The following list summarizes all red entries (i.e. new, unresolved issues) from the large list above. There should be none.
     88
     89[[ImageryCompare(error)]]