incorrectly pasted relation tags

[richlv]

see the attached testcase. select the upper way, right click relation in the "member of" section, choose select relation. ctrl+c.

select the lower way, add a new relation, click on "paste tags from buffer" button.

notice how one of the tags has the value only, not the tag itself. click 'ok', observe the contents of the new relation. one tag is lost.

josm 6891

[simon04]

Tracing this bug down revealed that the field with the (editing) focus is somehow cleared after correctly updating the table model.

This patch mitigates the problem by appending the tags to the end of the table … Not a great solution, though …

src/org/openstreetmap/josm/gui/tagging/TagEditorModel.java

@@ -209 +209 @@
         TagModel tag = get(name);
         if (tag == null) {
             tag = new TagModel(name, value);
-            int index = tags.size();
-            while (index >= 1 && tags.get(index - 1).getName().isEmpty() && tags.get(index - 1).getValue().isEmpty()) {
-                index--; // If last line(s) is empty, add new tag before it
-            }
-            tags.add(index, tag);
+            tags.add(tag);
         } else {
             tag.addValue(value);
         }

[Don-vip]

I can't reproduce with r13159, I think this is fixed. Can you please confirm?