Bug in JOSM when clicking an imagery link from HOT

[anonymous]

What steps will reproduce the problem?

1. Go here ​http://tasks.hotosm.org/job/422#task/38502/33662/16
2. Click on the imagery link (you have to accept the agreement first)

What is the expected result?

Loads imagery

What happens instead?

java.lang.IllegalArgumentException: {z} is not a valid TMS argument. Please check this server URL:
​http://hiu-maps.net/hot/1.0.0/juba-16jan2014-flipped/{z}/{x}/{y}.png

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-02-27 09:27:48
Last Changed Author: simon04
Revision: 6891
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-02-27 08:25:03 +0100 (Thu, 27 Feb 2014)
Last Changed Rev: 6891

Identification: JOSM/1.5 (6891 en) Linux Fedora release 20 (Heisenbug)
Memory Usage: 115 MB / 661 MB (57 MB allocated, but free)
Java version: 1.7.0_51, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Xbootclasspath/a:/usr/share/icedtea-web/netx.jar:/usr/share/java/js.jar, -Xms8m, -Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugin: FastDraw (30277)
Plugin: FixAddresses (30277)
Plugin: OpeningHoursEditor (30235)
Plugin: RoadSigns (30277)
Plugin: buildings_tools (30277)
Plugin: download_along (30277)
Plugin: fieldpapers (b49dadd)
Plugin: geotools (30277)
Plugin: imagery_offset_db (30277)
Plugin: jts (30277)
Plugin: junctionchecking (30277)
Plugin: mapdust (30277)
Plugin: opendata (30303)
Plugin: openstreetbugs (30277)
Plugin: pdfimport (30277)
Plugin: print (30233)
Plugin: public_transport (30277)
Plugin: reltoolbox (30277)
Plugin: reverter (30307)
Plugin: terracer (30277)
Plugin: turnlanes (30277)
Plugin: turnrestrictions (30307)
Plugin: utilsplugin2 (30277)
Plugin: wikipedia (30277)

java.lang.IllegalArgumentException: {z} is not a valid TMS argument. Please check this server URL:
http://hiu-maps.net/hot/1.0.0/juba-16jan2014-flipped/{z}/{x}/{y}.png
	at org.openstreetmap.josm.gui.layer.TMSLayer.checkUrl(TMSLayer.java:401)
	at org.openstreetmap.josm.gui.layer.TMSLayer.getTileSource(TMSLayer.java:375)
	at org.openstreetmap.josm.gui.layer.TMSLayer.<init>(TMSLayer.java:495)
	at org.openstreetmap.josm.gui.layer.ImageryLayer.create(ImageryLayer.java:146)
	at org.openstreetmap.josm.io.remotecontrol.handler.ImageryHandler$1.run(ImageryHandler.java:76)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

[anonymous]

If you add the same link through the imagery manager, it displays a warning prompt that the URL is not valid. So the bug presumably is that the remote control component doesn't catch the IllegalArgumentException and gracefully handle it.

[stoecker]

Note to anonym: If you want the root cause fixed, then tell the HOT team that the correct parameter is {zoom} and not {z}, see also Maps.

[Don-vip]

In 6902/josm:

fix #9791 - IllegalArgumentException when clicking an imagery link from HOT