Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9716 closed defect (fixed)

Mappaint style for osm object not updated when tags change

Reported by: bastiK Owned by: team
Priority: normal Milestone: 14.05
Component: Core mappaint Version:
Keywords: Cc:

Description

Drawing style is not updated when removing tags:

  • draw way
  • presets > relations > boundary
    • select "Boundary type: administrative" and "Administrative level: 1"; Ok

-> Way is drawn as dashed line

  • select relation
  • in tag dialog:
    • remove tag type=boundary
    • remove tag boundary=administrative
    • remove tag admin_level=1

(order is important)

-> dashed line is still drawn

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-02-11 02:35:25
Last Changed Author: Don-vip
Revision: 6836
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-02-11 01:23:37 +0100 (Tue, 11 Feb 2014)
Last Changed Rev: 6836

Identification: JOSM/1.5 (6836 en) Linux Ubuntu 12.10
Memory Usage: 213 MB / 1763 MB (53 MB allocated, but free)
Java version: 1.7.0_51, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u51-2.4.4-0ubuntu0.12.10.2
VM arguments: [-Djosm.restart=true, -Djosm.home=/home/te/.josm-latest, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Attachments (0)

Change History (10)

comment:1 Changed 6 years ago by bastiK

The type=boundary tag makes it a multipolygon, so this could be related to the multipolygon cache.

comment:2 Changed 6 years ago by Don-vip

Milestone: 14.03

comment:3 Changed 6 years ago by Klumbumbus

There is the same problem with all relation types.
How to reproduce:
use the following mapcss mappaint style

relation > way
{
	color: parent_tag("colour");
	width: 8;
}

create a way
create a relation with the way as member
give the relation the tag colour=green

then you can change the colour of the way by changing the value of the key 'colour' of the relation to yellow, red,...

If you use the edit relation window to change the colour then it works fine and the colour of the way updates.
If you select the relation and change the colour directly in the dialog panel on the right, then the colour of the way does not update. Then you need to modify the way e.g. add a node (just moving existing nodes or the whole way does not update the colour) or switch the mappaint style off and on again.

I tested with josm-stable (6891) and josm-latest (6909).

comment:4 Changed 6 years ago by Don-vip

@bastiK: did you start to work on this one?

comment:5 Changed 6 years ago by bastiK

no, feel free to assign to yourself...

comment:6 Changed 6 years ago by Don-vip

Milestone: 14.0314.04

I won't have enough time this month

comment:7 Changed 6 years ago by Don-vip

Milestone: 14.0414.05

comment:8 Changed 6 years ago by Klumbumbus

There is the same problem even without relations but with child selector.
How to reproduce:
Use the following mapcss mappaint style

way["addr:housenumber"] > node
{
	symbol-shape: circle;
	symbol-size: 20;
}

draw a bulding (e.g. with building tool)
add to the building the tag addr:housenumber=5

The mappaint does not update. Sometimes it does update 2 of the four nodes of the building when you move one node.

Tested with JOSM stable 7000 and latest 7080.
I hope this helps to track down the problem.

comment:9 Changed 6 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7091/josm:

fixed #9716 - Mappaint style for osm object not updated when tags change

comment:10 Changed 6 years ago by Klumbumbus

Thanks for the fix.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.