[patch] cleanup SlippyMapBBoxChooser from a TileSource implementation

[glebius]

Hi!

I'm working on fixing #7017 and decided to fix it not in a quick & dirty manner, but give some refresh to the tile sources code.

The first patch removes implementation of TileSource from JOSM code. This is a layering violation, since JOSM should only utilize TileSources, all implementations should live in jmapviewer. This one is created merely to change name of a TileSource, the rest of code is ugly cut'n'paste.

I have already changed default name of cycle map layer from "OSM Cycle Map" to "Cyclemap", so the attached patch will not introduce any user visible changes. All names would remain the same.

In a case if we really need to have different layer names in BBox chooser and in the main JOSM windows, I will just extend TileSource with a new constructor that takes String name argument. However, I doubt that would be needed.

In any case, the patch is needed to allow me freely work on TileSource class inside jmapviewer, without breaking JOSM build on every change.

[stoecker]

Was added in [3602]. I see no reason for this wrapper.

[stoecker]

In 6785/josm:

fix #9643 - remove unneeded wrapper class - patch by glebius

[stoecker]

BTW:

fix it not in a quick & dirty manner, but give some refresh to the tile sources code.

I like that. Quick and Dirty usually causes trouble later. A proper solution is better.

[Don-vip]

Replying to stoecker:

BTW:

fix it not in a quick & dirty manner.

I like that.

+1. Thanks a lot ! :)