Modify

Opened 5 years ago

Closed 5 years ago

#9609 closed defect (fixed)

validator corrects "elevation" to "layer"

Reported by: malenki Owned by: team
Priority: normal Milestone: 14.01
Component: Core validator Version:
Keywords: elevation validator automatic correction Cc:

Description

Cleaning some duplicate natural=peak today I discovered that the validator criticises the tag
elevation=* as invalid and offers to correct the affected objects.
The correction is, that "elevation" gets changed to "layer".

I propose to change "elevation" to "ele" for automatic corrections or – if "elevation=*" is ambiguous – to disable the correction button for this error.

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Don-vip

Milestone: 14.01

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6760/josm:

fix #9609 - tagchecker: handling of elevation tag:

  • do not replace by layer
  • remove elevation=0
  • do nothing for other values

comment:3 Changed 5 years ago by aceman

Resolution: fixed
Status: closedreopened

Why is elevation=0 removed? Yes, it means "sea level", but there are places in the world where this is true on "dry land" (think e.g. Dead Sea area). An object without any "elevation" tag means elevation unknown, not "0". That is a difference to "layer", where unset defaults to "0", not unknown.

And it seems "elevation" is the wrong key, it should be "ele" per the wiki. So where is that suggestion done in the code?

comment:4 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

Look for the data yourself:

http://www.overpass-api.de/api/xapi?*[elevation=0][@meta]

This tag is not used to indicate sea level but seems to be used for layer=0. It is ambiguous with positive values where we do not know if it's ele or layer, but I don't care about writing a test for it, it is not used enough (see taginfo).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.