Detect sports without physical features

[Don-vip]

[]From ​osmwiki:Key:sport, we should detect sport tags without a valid physical feature in that list:

• leisure=sports_centre
• leisure=stadium
• leisure=track (athletics, cycling, horse_racing, ...)
• leisure=pitch
• leisure=golf_course (golf, jogging, walking, ...)
• leisure=water_park
• leisure=swimming_pool (swimming, diving, gymnastics, ...)
• natural=beach
• natural=bare_rock
• landuse=recreation_ground
• landuse=piste (skiing, hiking, paragliding, ...)
• tourism=hotel (swimming, golf, tennis, ...)
• amenity=restaurant (10pin, ...)
• amenity=pub (billiard, darts, pinball, table_soccer ...)

This is a common mapping error. Maybe this list is not complete however.

[Don-vip]

this does not work:

*[sport][tourism != hotel][leisure !~ /^(sports_centre|stadium|pitch|golf_course|water_park|swimming_pool)$/][natural !~ /^(beach|bare_rock)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste)$/] {
    throwWarning: tr("sport without physical feature");
    assertMatch: "node sport=tennis";
    assertNoMatch: "node sport=tennis leisure=pitch";
    assertNoMatch: "node sport=beachvolleyball natural=beach";
    assertNoMatch: "node sport=skiiing landuse=piste";
    assertNoMatch: "node sport=swimming tourism=hotel";
    assertNoMatch: "node sport=10pin amenity=restaurant";
}

what's the good way of writing several "tag not present or not in a list" conditions ?

[simon04]

In 6859/josm:

see #9593 - MapCSS: fix matching of negated regular expressions for missing values

[simon04]

In 6860/josm:

fix #9593 - Detect sports without physical features - MapCSS test by Don-vip

[simon04]

In 6861/josm:

see #9593 - MapCSS: adapt MapCSS tests to negated regular expressions behaviour (see r6859)

[Don-vip]

Yay thanks !

[aceman]

The warning still fires on the leisure=track + sport=*. It looks like it is missing from the patch. Can you check if all the values are in as in the ticket description?

[Don-vip]

In 6877/josm:

see #9593 - validator: forgot leisure=track for "sport without physical feature" test

[admin@…]

what about club=sport?

[Luca]

Hi,
please add "natural=cliff" to the list of valid physical features.
Otherwise tagging it with sport=climbing give a warning message

[Procrastigator]

I would suggest also modifying the script so "disused" variants are taken into account. Currently I tagged a "disused:leisure=pitch" and I get the error message.

[Don-vip]

Please don't reopen old tickets and create a new one instead. Thanks.