Modify

Opened 6 years ago

Closed 3 years ago

#9593 closed enhancement (fixed)

Detect sports without physical features

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 14.02
Component: Core validator Version:
Keywords: Cc: simon04

Description (last modified by Don-vip)

[]From osmwiki:Key:sport, we should detect sport tags without a valid physical feature in that list:

  • leisure=sports_centre
  • leisure=stadium
  • leisure=track (athletics, cycling, horse_racing, ...)
  • leisure=pitch
  • leisure=golf_course (golf, jogging, walking, ...)
  • leisure=water_park
  • leisure=swimming_pool (swimming, diving, gymnastics, ...)
  • natural=beach
  • natural=bare_rock
  • landuse=recreation_ground
  • landuse=piste (skiing, hiking, paragliding, ...)
  • tourism=hotel (swimming, golf, tennis, ...)
  • amenity=restaurant (10pin, ...)
  • amenity=pub (billiard, darts, pinball, table_soccer ...)

This is a common mapping error. Maybe this list is not complete however.

Attachments (0)

Change History (14)

comment:1 Changed 6 years ago by Don-vip

Cc: simon04 added

this does not work:

*[sport][tourism != hotel][leisure !~ /^(sports_centre|stadium|pitch|golf_course|water_park|swimming_pool)$/][natural !~ /^(beach|bare_rock)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste)$/] {
    throwWarning: tr("sport without physical feature");
    assertMatch: "node sport=tennis";
    assertNoMatch: "node sport=tennis leisure=pitch";
    assertNoMatch: "node sport=beachvolleyball natural=beach";
    assertNoMatch: "node sport=skiiing landuse=piste";
    assertNoMatch: "node sport=swimming tourism=hotel";
    assertNoMatch: "node sport=10pin amenity=restaurant";
}

what's the good way of writing several "tag not present or not in a list" conditions ?

Last edited 6 years ago by Don-vip (previous) (diff)

comment:2 Changed 6 years ago by simon04

In 6859/josm:

see #9593 - MapCSS: fix matching of negated regular expressions for missing values

comment:3 Changed 6 years ago by simon04

Resolution: fixed
Status: newclosed

In 6860/josm:

fix #9593 - Detect sports without physical features - MapCSS test by Don-vip

comment:4 Changed 6 years ago by simon04

In 6861/josm:

see #9593 - MapCSS: adapt MapCSS tests to negated regular expressions behaviour (see r6859)

comment:5 Changed 6 years ago by Don-vip

Yay thanks !

comment:6 Changed 6 years ago by aceman

The warning still fires on the leisure=track + sport=*. It looks like it is missing from the patch. Can you check if all the values are in as in the ticket description?

comment:7 Changed 6 years ago by Don-vip

In 6877/josm:

see #9593 - validator: forgot leisure=track for "sport without physical feature" test

comment:8 Changed 5 years ago by admin@…

what about club=sport?

comment:9 Changed 5 years ago by anonymous

Resolution: fixedneedinfo

comment:10 Changed 5 years ago by mkoniecz

Resolution: needinfofixed

comment:11 Changed 4 years ago by Luca

Hi,
please add "natural=cliff" to the list of valid physical features.
Otherwise tagging it with sport=climbing give a warning message

comment:12 Changed 3 years ago by Procrastigator

I would suggest also modifying the script so "disused" variants are taken into account. Currently I tagged a "disused:leisure=pitch" and I get the error message.

comment:13 Changed 3 years ago by Procrastigator

Resolution: fixed
Status: closedreopened

comment:14 Changed 3 years ago by Don-vip

Description: modified (diff)
Resolution: fixed
Status: reopenedclosed

Please don't reopen old tickets and create a new one instead. Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.