#9535 closed defect (fixed)
Regression: Can't see which direction a way is going when selected & tagged with "tiger:reviewed=no" anymore
| Reported by: | rickmastfan67 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.01 |
| Component: | Core | Version: | latest |
| Keywords: | regression | Cc: | bastiK |
Description (last modified by )
This is a regression in r6627. Back in r6620, it worked fine and I could see which way the way was going when it was selected and had the "tiger:reviewed:no" tag on it. This was tested on a fresh profile with no plugins installed. I think something done in [6624] might have caused this to happen.
This was tested with way 11693763, which is tagged with "tiger:reviewed=no".
http://www.openstreetmap.org/way/11693763
This could become a major problem if this made it into the next tested build since there are over 12.6 Million ways with this tag in the USA still.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2014-01-05 02:34:30 Last Changed Author: stoecker Revision: 6627 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2014-01-04 20:21:07 +0100 (Sat, 04 Jan 2014) Last Changed Rev: 6627 Identification: JOSM/1.5 (6627 en) Windows 7 64-Bit Memory Usage: 156 MB / 1820 MB (86 MB allocated, but free) Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM VM arguments: [-Xmx2048M]
Attachments (1)
Change History (11)
Changed 9 years ago by
| Attachment: | 9535__tiger_reviewed-no_display_bug.png added |
|---|
comment:1 Changed 9 years ago by
| Summary: | Regression: Can't see which dirrection a way is going when selected & tagged with "tiger:reviewed:no" anymore → Regression: Can't see which direction a way is going when selected & tagged with "tiger:reviewed:no" anymore |
|---|
comment:2 Changed 9 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 9 years ago by
| Component: | Core mappaint → Core |
|---|---|
| Milestone: | → 14.01 |
| Priority: | minor → normal |
comment:4 Changed 9 years ago by
| Summary: | Regression: Can't see which direction a way is going when selected & tagged with "tiger:reviewed:no" anymore → Regression: Can't see which direction a way is going when selected & tagged with "tiger:reviewed=no" anymore |
|---|
comment:5 Changed 9 years ago by
| Cc: | bastiK added |
|---|
comment:6 Changed 9 years ago by
I assume the problem is, that getColor() does no longer properly handle an undefined "def" value?
comment:7 Changed 9 years ago by
I don't fully understand the problem. #9521 is because default values for colors were not saved, while colors preferences panel expects it. So I re-added the default value to get() and it solved the problem. That I don't understand is why it causes this as a side effect. Looks like a missing alpha value or something ?
comment:8 Changed 9 years ago by
Could also be, that semantics changed, so that now a value is used, where actually it was "null" before?
comment:10 Changed 9 years ago by
Big thanks, for fixing the problems related to my rework! I'll try to react faster next time... :)
To fix this regression one solution may be to revert r6624 and fix #9521 differently.