Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9450 closed enhancement (fixed)

Git mirror: Replace svn info for revision detection by git log+perl

Reported by: simon04 Owned by: Don-vip
Priority: minor Milestone: 14.01
Component: Core Version:
Keywords: Cc:

Description

From https://github.com/openstreetmap/josm/pull/5 by https://github.com/AlfonZ42:

I didn't like that revision detection (hacked long ago in https://github.com/openstreetmap/josm/commit/bcbc70ea2e5c51b5d27222fe69c7e963645ca263) was trying to access josm.openstreetmap.de (it made building impossible when offline) and revision number was not always correct (when working with older revisions).

I replaced svn info by git log + perl.
git log looks at the most recent commit message with git-svn-id, which is then processed by perl script that produces revision number and date, which are needed in build.xml.
In case perl is not found, the build doesn't fail, values fallback to UNKNOWN, as specified in build.xml.

Attachments (0)

Change History (6)

comment:1 Changed 5 years ago by Don-vip

Milestone: 14.01
Owner: changed from team to Don-vip
Status: newassigned

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 6540/josm:

fix #9450 - Allow to build JOSM from a git mirror clone with ant -Dgit_revision=true

comment:3 Changed 5 years ago by simon04

In 6545/josm:

see #9450 - JOSM build from a git mirror: remove need for perl script, automatically obtain revision from Git if SVN fails (removes need for git_revision=true)

comment:4 Changed 5 years ago by Don-vip

Better :) Thanks !

comment:5 Changed 5 years ago by simon04

Finally, using a git-svn-repository is fun. :)

comment:6 Changed 5 years ago by simon04

In 6585/josm:

fix #9501 see #9450 - JOSM build failed with SVN

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.