Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#9347 closed defect (fixed)

Improvement in incorrect roundabout validator message

Reported by: naoliv Owned by: team
Priority: minor Milestone: 13.12
Component: Core validator Version: latest
Keywords: Cc:

Description

When using the validator sometimes I see messages like this on the "incorrect roundabout" test:

Incorrect roundabout (highway: motorway_link instead of Incorrect roundabout (highway: motorway_link instead of unclassified))

The proper message should be only the inner one highway: motorway_link instead of unclassified

JOSM is:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-11-22 02:34:32
Last Changed Author: Don-vip
Revision: 6399
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-22 01:15:27 +0100 (Fri, 22 Nov 2013)
Last Changed Rev: 6399

Identification: JOSM/1.5 (6399 pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 323 MB / 1756 MB (78 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.12-4
VM arguments: [-Djava.net.useSystemProxies=true, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugin: AddrInterpolation (30034)
Plugin: Create_grid_of_ways (29854)
Plugin: ImageryCache (29946)
Plugin: PicLayer (29854)
Plugin: SimplifyArea (30017)
Plugin: buildings_tools (30057)
Plugin: editgpx (29854)
Plugin: geotools (29767)
Plugin: jts (29854)
Plugin: merge-overlap (30034)
Plugin: opendata (30034)
Plugin: pdfimport (29913)
Plugin: reverter (30031)
Plugin: tagging-preset-tester (30017)
Plugin: turnrestrictions (30034)
Plugin: undelete (29854)
Plugin: utilsplugin2 (30017)

Attachments (1)

example.osm.bz2​ (83.6 KB ) - added by naoliv 12 years ago.
It gives the message on the roudabout tagged with FIXME=roundabout

Download all attachments as: .zip

Change History (9)

comment:1 by Don-vip, 12 years ago

Owner: changed from team to naoliv
Status: new → needinfo

Can you attach an example please ?

by naoliv, 12 years ago

Attachment: example.osm.bz2​ added

It gives the message on the roudabout tagged with FIXME=roundabout

comment:2 by anonymous, 12 years ago

Owner: changed from naoliv to anonymous
Status: needinfo → new

Validate this example file and you should get the same initial message Incorrect roundabout (highway: motorway_link instead of Incorrect roundabout (highway: motorway_link instead of unclassified))

Where it gives the warning is also tagged as FIXME=roundabout

comment:3 by Don-vip, 12 years ago

Owner: changed from anonymous to team

comment:4 by Don-vip, 12 years ago

Resolution: → fixed
Status: new → closed

In 6407/josm:

fix #9347 - incorrect roundabout validator message + support of highway=*_link

comment:5 by skyper, 12 years ago

Resolution: fixed
Status: closed → reopened

The order of the last three categories should be:

  1. unclassified
  2. residential
  3. living_street

comment:6 by Don-vip, 12 years ago

Resolution: → fixed
Status: reopened → closed

In 6417/josm:

fix #9347 - order of classified highways

comment:7 by Don-vip, 12 years ago

Milestone: → 13.12 (6502)

comment:8 by stoecker, 8 years ago

Milestone: 13.12 (6502) → 13.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.