Opening-Hours test fails during the upload

[Lesath]

What steps will reproduce the problem?

1. Create a shop/restaurant
2. enter "opening_hours" with value "Mo-Su 18:00-1:00"
3. Try to upload the change

Could be reproduced reliable.

What is the expected result?

Data uploaded in Openstreetmap database.

What happens instead?

A crash - see stack trace.

Please provide any additional information below. Attach a screenshot if
possible.

Build-Date: 2013-11-07 12:56:57
Revision: 6372
Is-Local-Build: true

Identification: JOSM/1.5 (6372 SVN de) Mac OS X 10.8.5
Memory Usage: 336 MB / 507 MB (164 MB allocated, but free)
Java version: 1.6.0_65, Apple Inc., Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xbootclasspath/a:/System/Library/PrivateFrameworks/JavaApplicationLauncher.framework/Resources/LauncherSupport.jar, -Xmx512m, -Dapple.laf.useScreenMenuBar=true]
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: download_along (30017)
Plugin: turnlanes (30043)
Plugin: turnrestrictions (30034)

java.lang.RuntimeException: java.lang.IllegalArgumentException: Not expecting class class sun.org.mozilla.javascript.internal.NativeArray
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.checkOpeningHourSyntax(OpeningHourTest.java:97)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.check(OpeningHourTest.java:102)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.check(OpeningHourTest.java:109)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.visit(OpeningHourTest.java:117)
	at org.openstreetmap.josm.data.osm.Node.accept(Node.java:199)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:157)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:59)
	at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:198)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:221)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:271)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
	at java.awt.Component.processMouseEvent(Component.java:6414)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
	at java.awt.Component.processEvent(Component.java:6179)
	at java.awt.Container.processEvent(Container.java:2084)
	at java.awt.Component.dispatchEventImpl(Component.java:4776)
	at java.awt.Container.dispatchEventImpl(Container.java:2142)
	at java.awt.Component.dispatchEvent(Component.java:4604)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4618)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4279)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4209)
	at java.awt.Container.dispatchEventImpl(Container.java:2128)
	at java.awt.Window.dispatchEventImpl(Window.java:2492)
	at java.awt.Component.dispatchEvent(Component.java:4604)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:717)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:676)
	at java.awt.EventQueue$2.run(EventQueue.java:674)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:690)
	at java.awt.EventQueue$3.run(EventQueue.java:688)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:687)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Caused by: java.lang.IllegalArgumentException: Not expecting class class sun.org.mozilla.javascript.internal.NativeArray
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.getList(OpeningHourTest.java:68)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.checkOpeningHourSyntax(OpeningHourTest.java:86)
	... 46 more

[Don-vip]

Works for me with:

Build-Date: 2013-11-07 15:19:35
Revision: 6365
Is-Local-Build: true

Identification: JOSM/1.5 (6365 SVN en) Windows 7 64-Bit
Memory Usage: 155 MB / 1820 MB (92 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx2048M, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Probably another Apple Java 6 issue...

[Lesath]

Seems to be - it will work here with Oracle-JDK 1.7 on Apple OS X. Just changed the JDK:

Build-Date: 2013-11-07 12:56:57
Revision: 6372
Is-Local-Build: true

Identification: JOSM/1.5 (6372 SVN de) Mac OS X 10.8.5
Memory Usage: 212 MB / 910 MB (133 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: download_along (30017)
Plugin: turnlanes (30043)
Plugin: turnrestrictions (30034)

[Don-vip]

In 6373/josm:

see #9285 - should fix exception of opening_hours validator test with Apple Java 6

[Don-vip]

Can you check with Apple Java 6 if it works ? Thanks.

[Lesath]

Yes - the fix works for me:

Thanks for the quick fix!

Build-Date: 2013-11-07 16:35:18
Revision: 6373
Is-Local-Build: true

Identification: JOSM/1.5 (6373 SVN de) Mac OS X 10.8.5
Memory Usage: 81 MB / 507 MB (36 MB allocated, but free)
Java version: 1.6.0_65, Apple Inc., Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xbootclasspath/a:/System/Library/PrivateFrameworks/JavaApplicationLauncher.framework/Resources/LauncherSupport.jar, -Xmx512m, -Dapple.laf.useScreenMenuBar=true]
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: download_along (30017)
Plugin: turnlanes (30043)
Plugin: turnrestrictions (30034)

[Don-vip]

Thanks for the quick test ! :)

[stoecker]

Milestone renamed