Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#9242 closed defect (fixed)

confusing "A name:* translation is missing"

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 15.04
Component: Core validator Version:
Keywords: Cc:

Description

http://www.openstreetmap.org/browse/relation/3071561 is reported by Validator with this message, in category "Other".

I have no idea what is reported here (there are some not empty name:*, what is wrong here?), it would be benefit from better name.

Attachments (0)

Change History (8)

comment:1 in reply to:  description ; Changed 6 years ago by skyper

Replying to Bulwersator:

http://www.openstreetmap.org/browse/relation/3071561 is reported by Validator with this message, in category "Other".

I have no idea what is reported here (there are some not empty name:*, what is wrong here?), it would be benefit from better name.

name:en is missing and name:* is present.

comment:2 in reply to:  1 Changed 6 years ago by mkoniecz

Replying to skyper:

Replying to Bulwersator:

http://www.openstreetmap.org/browse/relation/3071561 is reported by Validator with this message, in category "Other".

I have no idea what is reported here (there are some not empty name:*, what is wrong here?), it would be benefit from better name.

name:en is missing and name:* is present.

Is it always about name:en? In this case "A name:en translation is missing" would be preferable.

comment:3 Changed 6 years ago by Don-vip

It's a bit more complicated:

/**
 * Check for missing name:* translations.
 * <p>
 * This test finds multilingual objects whose 'name' attribute is not
 * equal to any 'name:*' attribute and not a composition of some
 * 'name:*' attributes separated by ' - '.
 * <p>
 * For example, a node with name=Europe, name:de=Europa should have
 * name:en=Europe to avoid triggering this test.  An object with
 * name='Suomi - Finland' should have at least name:fi=Suomi and
 * name:sv=Finland to avoid a warning (name:et=Soome would not
 * matter).  Also, complain if an object has some name:* attribute but
 * no name.
 *
 * @author Skela
 */

See source:/trunk/src/org/openstreetmap/josm/data/validation/tests/NameMismatch.java

Last edited 6 years ago by Don-vip (previous) (diff)

comment:4 Changed 6 years ago by mkoniecz

So it something like "value of field name is not used in any of name:* translations".
And sometimes "there are name:* values, but there is no value for field name"

comment:5 Changed 5 years ago by anonymous

+1 on the confusion. Even after reading this ticket, I'm murky on what this message wants of me.

comment:6 Changed 5 years ago by stoecker

Milestone: 15.04

comment:7 Changed 5 years ago by simon04

Resolution: fixed
Status: newclosed

In 8239/josm:

fix #9242 - Validator: reword "A name:* translation is missing" test result

comment:8 Changed 5 years ago by aceman

OK, but this test is only triggered if there is any name:* existing? And only then it checks if any name:* matches name ?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.