Opened 12 years ago

Last modified 8 years ago

#9229 closed defect

Localised URL mistakes in the defaultpresets.xml — at Version 6

Reported by: DeeHants Owned by:
Priority: normal Milestone: 13.11
Component: Internal preset Version: latest
Keywords: preset Cc: stoecker

Description (last modified by Don-vip)

While creating my own preset file, I created an XSD schema for it, and noticed several mistakes in the defaultpresets.xml.

I've attached a patch based on r6326

Transport/Railway/Rail/voltage has the length attribute spelt incorrectly.
Facilities/Education/Driving School/license_classes should be a combo not a text as it has values.
Facilities/Facilities/Fire Hydrant/fire_hydrant:count shouldn't have a blank values tag as it's a text.

r6325 also seems to have introduced a couple of oddities with regards to zh-hans.href and zh-hant.href on:
Highways/Barriers/Toll Booth
Highways/Barriers/Wall
Transport/Car/Fuel
Transport/Public Transport (legacy)/Bus Stop
Facilities/Accommodation/Alpine Hut
Facilities/Food+Drinks/Café
Facilities/Food+Drinks/Bar
Facilities/Culture/Place of Worship
Facilities/Facilities/Toilets
Facilities/Facilities/Bench
Geography/Geography/Peak
Geography/Land use/Cemetery

While these are all linked to localised pages on the wiki, they are also incorrect.

I'll also attach my current schema to another ticket

Change History (7)

by DeeHants, 12 years ago

Attachment: defaultpresets.xml.patch added

Patch to fix the mistakes/schema errors in defaultpresets.xml

comment:1 by Don-vip, 12 years ago

In 6328/josm:

see #9229 - Mistakes in the defaultpresets.xml (modified patch by DeeHants)

comment:2 by Don-vip, 12 years ago

Owner: changed from team to DeeHants
Status: newneedinfo

Thanks for the patch, could you please attach another one for the other issue you mentioned ?

comment:3 by skyper, 12 years ago

Component: CoreInternal preset
Summary: Mistakes in the defaultpresets.xml[Patch] Mistakes in the defaultpresets.xml

comment:4 by skyper, 12 years ago

Summary: [Patch] Mistakes in the defaultpresets.xmlMistakes in the defaultpresets.xml

comment:5 by DeeHants, 12 years ago

Owner: DeeHants removed
Status: needinfonew
Summary: Mistakes in the defaultpresets.xmlLocalised URL mistakes in the defaultpresets.xml

I've had another look and the zh-hant and zh-hans are both valid, but I don't know the internals of JOSM and its preset localisation.
Some of the local codes use xx_YY while the new ones have been added as zh-XXXX.
Maybe someone that knows it better can suggest the correct corrections to make :)

comment:6 by Don-vip, 12 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.