#9229 closed defect (fixed)
Localised URL mistakes in the defaultpresets.xml
| Reported by: | DeeHants | Owned by: | stoecker |
|---|---|---|---|
| Priority: | normal | Milestone: | 13.11 |
| Component: | Internal preset | Version: | latest |
| Keywords: | preset | Cc: | stoecker |
Description (last modified by )
While creating my own preset file, I created an XSD schema for it, and noticed several mistakes in the defaultpresets.xml.
I've attached a patch based on r6326
Transport/Railway/Rail/voltage has the length attribute spelt incorrectly.
Facilities/Education/Driving School/license_classes should be a combo not a text as it has values.
Facilities/Facilities/Fire Hydrant/fire_hydrant:count shouldn't have a blank values tag as it's a text.
r6325 also seems to have introduced a couple of oddities with regards to zh-hans.href and zh-hant.href on:
Highways/Barriers/Toll Booth
Highways/Barriers/Wall
Transport/Car/Fuel
Transport/Public Transport (legacy)/Bus Stop
Facilities/Accommodation/Alpine Hut
Facilities/Food+Drinks/Café
Facilities/Food+Drinks/Bar
Facilities/Culture/Place of Worship
Facilities/Facilities/Toilets
Facilities/Facilities/Bench
Geography/Geography/Peak
Geography/Land use/Cemetery
While these are all linked to localised pages on the wiki, they are also incorrect.
I'll also attach my current schema to another ticket
Attachments (1)
Change History (12)
Changed 10 years ago by
| Attachment: | defaultpresets.xml.patch added |
|---|
comment:2 Changed 10 years ago by
| Owner: | changed from team to DeeHants |
|---|---|
| Status: | new → needinfo |
Thanks for the patch, could you please attach another one for the other issue you mentioned ?
comment:3 Changed 10 years ago by
| Component: | Core → Internal preset |
|---|---|
| Summary: | Mistakes in the defaultpresets.xml → [Patch] Mistakes in the defaultpresets.xml |
comment:4 Changed 10 years ago by
| Summary: | [Patch] Mistakes in the defaultpresets.xml → Mistakes in the defaultpresets.xml |
|---|
comment:5 Changed 10 years ago by
| Owner: | DeeHants deleted |
|---|---|
| Status: | needinfo → new |
| Summary: | Mistakes in the defaultpresets.xml → Localised URL mistakes in the defaultpresets.xml |
I've had another look and the zh-hant and zh-hans are both valid, but I don't know the internals of JOSM and its preset localisation.
Some of the local codes use xx_YY while the new ones have been added as zh-XXXX.
Maybe someone that knows it better can suggest the correct corrections to make :)
comment:6 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:7 Changed 10 years ago by
| Cc: | stoecker added |
|---|
Dirk,
We're using zh_CN and zh_TW here:
source:trunk/src/org/openstreetmap/josm/tools/I18n.java#L381
But from r6325 zh-hans and zh-hant:
[6325/trunk/data/defaultpresets.xml]
Is it a problem ? Maybe the script needs special treatments for chinese ?
comment:8 Changed 10 years ago by
| Owner: | set to stoecker |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
In 6337/josm:
comment:9 Changed 10 years ago by
Can't everybody use the same specification? Why a different method for each language? Pff.
comment:10 Changed 10 years ago by
| Milestone: | → 13.11 (6383) |
|---|
Patch to fix the mistakes/schema errors in defaultpresets.xml