Modify

Opened 6 years ago

Closed 6 years ago

Last modified 22 months ago

#9229 closed defect (fixed)

Localised URL mistakes in the defaultpresets.xml

Reported by: DeeHants Owned by: stoecker
Priority: normal Milestone: 13.11
Component: Internal preset Version: latest
Keywords: preset Cc: stoecker

Description (last modified by Don-vip)

While creating my own preset file, I created an XSD schema for it, and noticed several mistakes in the defaultpresets.xml.

I've attached a patch based on r6326

Transport/Railway/Rail/voltage has the length attribute spelt incorrectly.
Facilities/Education/Driving School/license_classes should be a combo not a text as it has values.
Facilities/Facilities/Fire Hydrant/fire_hydrant:count shouldn't have a blank values tag as it's a text.

r6325 also seems to have introduced a couple of oddities with regards to zh-hans.href and zh-hant.href on:
Highways/Barriers/Toll Booth
Highways/Barriers/Wall
Transport/Car/Fuel
Transport/Public Transport (legacy)/Bus Stop
Facilities/Accommodation/Alpine Hut
Facilities/Food+Drinks/Café
Facilities/Food+Drinks/Bar
Facilities/Culture/Place of Worship
Facilities/Facilities/Toilets
Facilities/Facilities/Bench
Geography/Geography/Peak
Geography/Land use/Cemetery

While these are all linked to localised pages on the wiki, they are also incorrect.

I'll also attach my current schema to another ticket

Attachments (1)

defaultpresets.xml.patch (1.8 KB) - added by DeeHants 6 years ago.
Patch to fix the mistakes/schema errors in defaultpresets.xml

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by DeeHants

Attachment: defaultpresets.xml.patch added

Patch to fix the mistakes/schema errors in defaultpresets.xml

comment:1 Changed 6 years ago by Don-vip

In 6328/josm:

see #9229 - Mistakes in the defaultpresets.xml (modified patch by DeeHants)

comment:2 Changed 6 years ago by Don-vip

Owner: changed from team to DeeHants
Status: newneedinfo

Thanks for the patch, could you please attach another one for the other issue you mentioned ?

comment:3 Changed 6 years ago by skyper

Component: CoreInternal preset
Summary: Mistakes in the defaultpresets.xml[Patch] Mistakes in the defaultpresets.xml

comment:4 Changed 6 years ago by skyper

Summary: [Patch] Mistakes in the defaultpresets.xmlMistakes in the defaultpresets.xml

comment:5 Changed 6 years ago by DeeHants

Owner: DeeHants deleted
Status: needinfonew
Summary: Mistakes in the defaultpresets.xmlLocalised URL mistakes in the defaultpresets.xml

I've had another look and the zh-hant and zh-hans are both valid, but I don't know the internals of JOSM and its preset localisation.
Some of the local codes use xx_YY while the new ones have been added as zh-XXXX.
Maybe someone that knows it better can suggest the correct corrections to make :)

comment:6 Changed 6 years ago by Don-vip

Description: modified (diff)

comment:7 Changed 6 years ago by Don-vip

Cc: stoecker added

Dirk,
We're using zh_CN and zh_TW here:
source:trunk/src/org/openstreetmap/josm/tools/I18n.java#L381

But from r6325 zh-hans and zh-hant:
[6325/trunk/data/defaultpresets.xml]

Is it a problem ? Maybe the script needs special treatments for chinese ?

comment:8 Changed 6 years ago by stoecker

Owner: set to stoecker
Resolution: fixed
Status: newclosed

In 6337/josm:

fix #9229 - proper coding of chines links

comment:9 Changed 6 years ago by stoecker

Can't everybody use the same specification? Why a different method for each language? Pff.

comment:10 Changed 6 years ago by Don-vip

Milestone: 13.11 (6383)

comment:11 Changed 22 months ago by stoecker

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.