[Patch] copy&paste of tags vanished

[malenki]

In the latest versions of JOSM the ability to copy and paste tags of an object has vanished.

Before this happened it was possible to:

1. mark an object
2. press ctrl-c
3. mark an other object
4. press ctrl-shift-v
5. and all tags from the first marked object were pasted to the other object

Now there is only pasted $Object_type=$Object_ID, e.g.: Line 108651339

It would be nice if the old behaviour would be restored.
Additionally I don't see much sense in copypasting object types and IDs.

[malenki]

Ticket #9199 has been marked as a duplicate of this ticket.

[skyper]

Seems to be a regression of r6320 (#4644).

I had this problem with more than one object selected to copy of but with a single node it did work.

[anonymous]

I won’t be able to work on this until next Thursday. I guess this falls into a stabilize-cycle, so can you please revert my patch until I can have a look at it?

[julianladisch]

Patch = revert r6320

[anonymous]

Ticket #9218 has been marked as a duplicate of this ticket.

[Schusch]

Hi - I can confirm this ticket. From snapshot 6319 to 6320 it changed. copying tags from one object and trying to paste them into another object leads to copying the element number into this object ... went back to 6319.

[akks]

It is because of buffer contents check

if (buf == null || buf.isEmpty() || buf.matches("(\\d+,)*\\d+")) {
            pasteTagsFromJOSMBuffer(selection);
        }

(\\d+,)*\\d+ no longer matches the JOSM-generated buffer string after r6320, the exact new format is unknown because of internationalization.
If we skip the buf.matches checking, then copy-pasted JOSM buffer will be ignored if any text is in buffer - we need a way to know if current text buffer is associated with JOSM object or not (currently it is done by format checking).

[akks]

In 6321/josm:

fix #9200: repair tags copy-pasting

[akks]

It seems that no one had time to fix this before (just like me).

I did not revert the patch but disabled translation (node 1234, way 10 for all locales) and changed buffer-detection regexp to accept such text.
Be sure to change CopyAction.CLIPBOARD_REGEXP constant if the format of text changes.

[skyper]

Replying to akks:

I did not revert the patch but disabled translation (node 1234, way 10 for all locales) and changed buffer-detection regexp to accept such text.
Be sure to change CopyAction.CLIPBOARD_REGEXP constant if the format of text changes.

Hope, this fixes all the warning spamming the terminal, too.

[bastiK]

Ticket #9224 has been marked as a duplicate of this ticket.

[stoecker]

Milestone renamed