Modify

Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#9185 closed enhancement (fixed)

[patch] update of opening_hours and other time formats

Reported by: skyper Owned by: team
Priority: minor Milestone: 13.11
Component: Internal preset Version:
Keywords: opening hours delimiter Cc: brycenesbitt

Description

I did update the example values of opening_hours + *_times using delimiter. Please find attached patch.

I am not sure about:

  • opening_hours on highway=streetlamp. Thought this is operating_times.
  • what values are useful with aed ?
  • need some better examples for place_of_worship but I do not attend any services.

Attachments (7)

open_hour.diff (85.7 KB) - added by skyper 6 years ago.
patch
open_hour_v2.diff (275.3 KB) - added by skyper 6 years ago.
updated patch
open_hour_v3.diff (95.9 KB) - added by skyper 6 years ago.
open_hour + saddle
white_space_unify.diff (44.6 KB) - added by skyper 6 years ago.
white space unify
open_hour_v4.diff (97.5 KB) - added by skyper 6 years ago.
patch version 4
peak.svg (2.3 KB) - added by skyper 6 years ago.
peak
saddle.svg (2.4 KB) - added by skyper 6 years ago.
saddle

Download all attachments as: .zip

Change History (19)

Changed 6 years ago by skyper

Attachment: open_hour.diff added

patch

Changed 6 years ago by skyper

Attachment: open_hour_v2.diff added

updated patch

comment:1 Changed 6 years ago by skyper

Cc: brycenesbitt added

I did update the values for place_of_worship.

On the run, I added natural=saddle (#9186) and unified white space with sed. Especially removing the ones after space.

Last edited 6 years ago by skyper (previous) (diff)

comment:2 Changed 6 years ago by brycenesbitt

For "aed" the standard values are fine (in particular "24/7").


Another value would be very very useful, but it requires some discussion: opening_hours=inherit
You'd use that for an aed inside a shopping mall, where the aed's access hours should match that of
the enclosing way.

comment:3 in reply to:  2 Changed 6 years ago by skyper

Replying to brycenesbitt:

For "aed" the standard values are fine (in particular "24/7").

Guess we do not need any of the extra values and I gonna leave it to be changed with upcoming decision about the tag.

comment:4 in reply to:  1 ; Changed 6 years ago by skyper

Replying to skyper:

Especially removing the ones after space.

I do not like this anymore. Gonna rework the patch.

Changed 6 years ago by skyper

Attachment: open_hour_v3.diff added

open_hour + saddle

Changed 6 years ago by skyper

Attachment: white_space_unify.diff added

white space unify

comment:5 in reply to:  4 Changed 6 years ago by skyper

Replying to skyper:

I do not like this anymore. Gonna rework the patch.

Find attached version 3 including the open_hour updates, add of saddle (#9186), small updates of shops plus missed wili links.

For the unification of white space I prepared a separate patch only adding a white space before />.

comment:6 Changed 6 years ago by Don-vip

In 6347/josm:

see #9185 - white space unity in presets (patch by skyper)

comment:7 Changed 6 years ago by Don-vip

Two remarks for the patch:

  • I cannot apply it now, can you make a v4 aligned to r6347 ?
  • Can you provide a better saddle icon and attach it in order to have a local file and not a link to OSM wiki ?

Thanks.

comment:8 in reply to:  7 ; Changed 6 years ago by skyper

Replying to Don-vip:

Two remarks for the patch:

  • I cannot apply it now, can you make a v4 aligned to r6347 ?

Sure.

  • Can you provide a better saddle icon and attach it in order to have a local file and not a link to OSM wiki ?

I did use the attached one which is similar to peak. I can make a (bigger) similar one as .svg if it is needed or do did I get you wrong ?

Changed 6 years ago by skyper

Attachment: open_hour_v4.diff added

patch version 4

Changed 6 years ago by skyper

Attachment: peak.svg added

peak

Changed 6 years ago by skyper

Attachment: saddle.svg added

saddle

comment:9 in reply to:  8 Changed 6 years ago by skyper

Replying to skyper:

Replying to Don-vip:

Two remarks for the patch:

  • I cannot apply it now, can you make a v4 aligned to r6347 ?

Sure.

Please find attached version 4

  • Can you provide a better saddle icon and attach it in order to have a local file and not a link to OSM wiki ?

I did use the attached one which is similar to peak. I can make a (bigger) similar one as .svg if it is needed or do did I get you wrong ?

I did make a .svg file for saddle saddle and peak peak. Feel free to change it.

comment:10 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6358/josm:

fix #9185, fix #9187 - presets/map style update:

  • update of opening_hours + general stuff on shops (patch by skyper)
  • support of natural=saddle with new icon for natural=peak (modified icons by skyper)

comment:11 Changed 6 years ago by Don-vip

Milestone: 13.11 (6383)

comment:12 Changed 2 years ago by stoecker

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.