Opened 11 years ago

Last modified 11 years ago

#9085 new defect

opening_hours, "off" and OpeningHoursEdit

Reported by: A_Pirard Owned by: boman
Priority: normal Milestone:
Component: Plugin openinghourseditor Version: tested
Keywords: Cc: A_Pirard


I have (had?) to code opening_hours for a street parking closed on Fridays 14:00 till 22:00.
I have been unable to do that with OpeningHoursEdit, neither intuitively nor after reading its doc.
After setting 24/7, which makes sense, it seemed not allowing to add an exception.
I read the doc for opening_hours, it looked like I had to use "off" but it's not documented (just shows in examples), especially: what must be before the "off" range to mean "all the time"?
I tried to make it "24/7 Fr 14:00-22:00 off" or "Fr 14:00-22:00 off" and OpeningHoursEdit reports an error on "24/7" and 22:0"0" respectively.
I bet for "Fr 14:00-22:00" but neither the OpeningHoursEdit diagram nor the nonexistent "off" documentation would tell me if that's correct.

Attachments (0)

Change History (4)

comment:1 by aceman, 11 years ago

what about explaining the times explictly like "Mo-Th 00:00-24:00; Fr 00:00-14:00".

But yes, it would be nice if you draw such hours in the timetable and the plugin would automatically optimize it to "24/7; Fr 14:00-22:00 off" if that is valid.
I'd say the plugin could add "off" clauses where it made sense, no need to allow the user to input them manually.

comment:2 by A_Pirard, 11 years ago

That's strange. On the tagging@osm mailing list

  • someone told me that "off" is optional; of course not
  • someone told me to use 24/7
  • then someone told me that that was wrong, to use nothing
  • then I felt that a syntax diagram was needed and I made and proposed one
  • then someone told be that there was a syntax diagram already
  • there was absolutely no link to it in opening-hours=* and I added one
  • then someone pointed out that there exist "open" and "closed"
  • "Mo-Th 00:00-24:00; Fr 00:00-14:00" is certainly not the simplest to understand, the proof being that it is wrong, it should be "Mo-Th 00:00-24:00; Fr 00:00-14:00; Fr 22:00-24:00; Sa-Su 00:00-24:00 "
  • your 24/7; Fr 14:00-22:00 off is wrong too, it should be Fr 14:00-22:00 off or open; Fr 14:00-22:00 off

OpeningHoursEdit has a subtracting mode, but not obvious to notice and I'm not sure it uses off indeed, even in subtracting mode.

That's Openstreetmap: fuzzy and almost as many ways to tag as subscribers

comment:3 by skyper, 11 years ago

Simple 00:00-24:00; Fr 00:00-14:00 would be enough

EDT: forgot 2 hours: 00:00-24:00; Fr 00:00-14:00,22:00-24:00

Last edited 11 years ago by skyper (previous) (diff)

comment:4 by aceman, 11 years ago

Yeah, so if we have drawn all the wished times in the timetable, the plugin should choose some valid representation (even if not optimal). I am sure if you manually did the intervals the resulting representation would be valid (just not using "off" so not the shortest).

My point being that OpeningHoursEdit plugin can represent what the original poster wanted, just not with the "off" keyword. But there are other valid ways that the plugin supports.

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain boman.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from boman to the specified user.
Next status will be 'needinfo'. The owner will be changed from boman to A_Pirard.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from boman to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.