Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#9071 closed defect (fixed)

[Patch] Default tagging incorrect when I make a route_master relation from Public transport preset

Reported by: Davlak Owned by: team
Priority: normal Milestone: 13.11
Component: Internal preset Version: latest
Keywords: Cc:

Description

When I make a router_master relation from public transport preset, the default tagging inside the relation is not correct.
JOSM give to the relation the tag "type=route_master"+"route=bus/tram/subway/etc." instead of "type=route_master"+"route_master=bus/tram/subway/etc."

Attachments (4)

Cattura di schermata (160).png​ (685.0 KB ) - added by Davlak 12 years ago.
Screenshot
josm_9071.diff​ (779 bytes ) - added by skyper 12 years ago.
patch
josm_9071_v2.diff​ (4.3 KB ) - added by skyper 12 years ago.
second version with validator test
josm_9071_v3.diff​ (4.3 KB ) - added by skyper 12 years ago.
patch version 3

Download all attachments as: .zip

Change History (12)

by Davlak, 12 years ago

Attachment: Cattura di schermata (160).png​ added

Screenshot

by skyper, 12 years ago

Attachment: josm_9071.diff​ added

patch

comment:1 by skyper, 12 years ago

Summary: Default tagging incorrect when I make a route_master relation from Public transport preset → [Patch] Default tagging incorrect when I make a route_master relation from Public transport preset
Version: → latest

Find attached patch​ fixing the problem

comment:2 by skyper, 12 years ago

A validator check which searches for route_master=* (route=*) in the appropriate relations would be nice.

comment:3 by skyper, 12 years ago

Ticket #9095 has been marked as a duplicate of this ticket.

by skyper, 12 years ago

Attachment: josm_9071_v2.diff​ added

second version with validator test

comment:4 by skyper, 12 years ago

I did attach a second version​ with my first tagchecker test. Please tell me if you have problems with the patch as it is also the first try with several files.

I do not know how to automatically change route -> route_master which would be even better.

by skyper, 12 years ago

Attachment: josm_9071_v3.diff​ added

patch version 3

comment:5 by skyper, 12 years ago

I did mess up my new validator string. Find updated patch version 3​ attached.

comment:6 by stoecker, 12 years ago

Resolution: → fixed
Status: new → closed

In 6250/josm:

fix #9071 - fix route_master relation

comment:7 by Don-vip, 12 years ago

Milestone: → 13.11 (6383)

comment:8 by stoecker, 8 years ago

Milestone: 13.11 (6383) → 13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.