Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#9060 closed enhancement (fixed)

[patch] Add "toll" in Motorway preset

Reported by: davide.pri@… Owned by: team
Priority: normal Milestone: 13.11
Component: Internal preset Version:
Keywords: toll Cc:

Description

Often the motorways have a toll, so I think the tag "toll=yes/no" should be added directly in motorway preset, in addition to the existent in Road restriction preset.

Attachments (3)

josm_9060.diff​ (5.3 KB ) - added by skyper 12 years ago.
patch
josm_9060_v2.diff​ (5.3 KB ) - added by skyper 12 years ago.
updated patch
josm_9060_v3.diff​ (5.3 KB ) - added by AlfonZ 12 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 by skyper, 12 years ago

Keywords: toll added

comment:2 by Don-vip, 12 years ago

Resolution: → fixed
Status: new → closed

In 6225/josm:

fix #9060 - Add "toll" in Motorway preset

comment:3 by skyper, 12 years ago

Resolution: fixed
Status: closed → reopened

This should at least also be added to motorway_link and trunk plus tunnel and bridges.

by skyper, 12 years ago

Attachment: josm_9060.diff​ added

patch

in reply to:  3 comment:4 by skyper, 12 years ago

Replying to skyper:

This should at least also be added to motorway_link and trunk plus tunnel and bridges.

Find attached patch​ which adds toll and removes some unneeded "default=off"

comment:5 by skyper, 12 years ago

Summary: Add "toll" in Motorway preset → [patch] Add "toll" in Motorway preset

comment:6 by skyper, 12 years ago

Anything wrong with this patch ?

comment:7 by Don-vip, 12 years ago

Didn't notice, sorry. There are so many tickets :)

comment:8 by Don-vip, 12 years ago

I have trouble to apply it can you please attach a new version ?
Thanks.

by skyper, 12 years ago

Attachment: josm_9060_v2.diff​ added

updated patch

in reply to:  8 comment:9 by skyper, 12 years ago

Replying to Don-vip:

I have trouble to apply it can you please attach a new version ?
Thanks.

Here​ you go. Once again a simple patch original_file < patch_file did work.

by AlfonZ, 12 years ago

Attachment: josm_9060_v3.diff​ added

comment:10 by AlfonZ, 12 years ago

josm_9060.diff​ and josm_9060_v2.diff​ are the same.
My svn patch $diff fails with them as well, patch $file $diff succeeds. The output from svn diff after patching is in josm_9060_v3.diff​.
The difference between v1/v2 and v3 is space vs. tab in the header.

  • josm_9060.diff

     
    11Index: data/defaultpresets.xml
    22===================================================================
    3 --- data/defaultpresets.xml (revision 6296)
    4 +++ data/defaultpresets.xml (working copy)
     3--- data/defaultpresets.xml     (revision 6296)
     4+++ data/defaultpresets.xml     (working copy)
    55@@ -195,12 +195,15 @@
    66                 <combo key="lanes" text="Lanes" values="1,2,3,4,5" length="3" />
    77                 <text key="maxspeed" text="Max. speed (km/h)" />
Last edited 12 years ago by AlfonZ (previous) (diff)

in reply to:  10 comment:11 by skyper, 12 years ago

Replying to AlfonZ:

josm_9060.diff​ and josm_9060_v2.diff​ are the same.
My svn patch $diff fails with them as well, patch $file $diff succeeds. The output from svn diff after patching is in josm_9060_v3.diff​.
The difference between v1/v2 and v3 is space vs. tab in the header.

Sorry, I was not aware of this. Thanks for noticing.

comment:12 by Don-vip, 12 years ago

Resolution: → fixed
Status: reopened → closed

In 6298/josm:

fix #9060 - add more toll checks in internal preset (patch by skyper)

comment:13 by Don-vip, 11 years ago

Milestone: → 13.11 (6383)

comment:14 by stoecker, 8 years ago

Milestone: 13.11 (6383) → 13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.