buildings_tools plugin fails with JOSM latest (6210)

[James Derrick <orders@…>]

Steps to reproduce:

1. Update JOSM (6210 fails, 6115 works)
2. Hit 'b' to create a building with buildings_tools (29596) plugin
3. Move the mouse pointer - unexpected exception

An unexpected exception occurred that may have come from the 'buildings_tools' plug-in. According to the information within the plug-in, the author is Upliner. Try updating to the newest version of this plug-in before reporting a bug. Should the plug-in be disabled?

4. Disable plugin (really reduces productivity)

Has the plugin API changed, requiring a plugin update?
​http://wiki.openstreetmap.org/wiki/JOSM/Plugins/BuildingsTools
​http://www.openstreetmap.org/user/Upliner

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-31 01:34:56
Last Changed Author: Don-vip
Revision: 6210
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-30 19:10:56 +0200 (Fri, 30 Aug 2013)
Last Changed Rev: 6210

Identification: JOSM/1.5 (6210 en_GB) Linux Fedora 19 (Schrödinger’s Cat)
Memory Usage: 212 MB / 1768 MB (140 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Dataset consistency test: No problems found

Plugin: PicLayer (29601)
Plugin: buildings_tools (29596)
Plugin: measurement (29625)
Plugin: terracer (29623)

org.openstreetmap.josm.plugins.PluginException: An error occurred in plug-in buildings_tools
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:32)
	at org.openstreetmap.josm.Main.setMapFrame(Main.java:293)
	at org.openstreetmap.josm.Main.createMapFrame(Main.java:460)
	at org.openstreetmap.josm.Main.addLayer(Main.java:449)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$DownloadTask.finish(DownloadOsmTask.java:282)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable$1.run(PleaseWaitRunnable.java:90)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:241)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:154)
	at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:182)
	at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:221)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:219)
	at java.awt.Dialog.show(Dialog.java:1082)
	at java.awt.Component.show(Component.java:1651)
	at java.awt.Component.setVisible(Component.java:1603)
	at java.awt.Window.setVisible(Window.java:1014)
	at java.awt.Dialog.setVisible(Dialog.java:1005)
	at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor$4.run(PleaseWaitProgressMonitor.java:172)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:29)
	... 40 more
Caused by: java.lang.VerifyError: (class: buildings_tools/Building, method: findNode signature: (Lorg/openstreetmap/josm/data/coor/EastNorth;)Lorg/openstreetmap/josm/data/osm/Node;) Incompatible argument to function
	at buildings_tools.DrawBuildingAction.<init>(DrawBuildingAction.java:63)
	at buildings_tools.BuildingsToolsPlugin.mapFrameInitialized(BuildingsToolsPlugin.java:34)
	... 45 more

[skyper]

Please update your plugins and report if it is still crashing. Thanks

[Don-vip]

Current (and required) version of this plugin is 29854. Please update.

[James Derrick <orders@…>]

Can you confirm the latest RELEASED version please?

JOSM 6210
Edit -> Preferences
Plugins
Update plug-ins
'All installed plug-ins are up to date. JOSM does not have to download newer versions.'
buildings_tools: Version 29596 (local: 29596)

This shows the latest RELEASED version is 29596, so is there an issue between the dev repository and the outside world please?

The OSM Wiki points to:
​http://wiki.openstreetmap.org/wiki/JOSM/Plugins/BuildingsTools
​http://svn.openstreetmap.org/applications/editors/josm/plugins/buildings_tools/

The SVN repository reports version 29909, although the build.xml seems to confirm something changed below JOSM v6162. From the SVN readme files, it looks like JOSM v6210 should be able to update to 29909 if it were active and mirrored out.

[Don-vip]

You have to hit "Refresh list" first.
See ​http://josm.openstreetmap.de/plugin for the latest version known by JOSM website (29854 atm).

[James Derrick <orders@…>]

JOSM 6210 after Download list - see wrong Version

[James Derrick <orders@…>]

Yes, did that. :-)

Looks like an issue with the Plug-ins update code in JOSM 6210.

JOSM 6210
Edit -> Preferences
Plugins
Press 'Download list'

'Downloading plug-in list...'

Still shows 'buildings_tools: Version 29596 (local: 29596)'

Press 'Update plug-ins'

'All installed plug-ins are up to date. JOSM does not have to download newer versions.'

Press 'Configure sites...'

​http://josm.openstreetmap.de/plugin%<?plugins=>

This seems to match the URL you gave in comment:4

Opening the URL in a browser gives:
<snip>

6082_Plugin-Url: 29778;​http://svn.openstreetmap.org/!svn/bc/29785/applications/editors/josm/dist/buildings_tools.jar
5960_Plugin-Url: 29596;​http://svn.openstreetmap.org/!svn/bc/29597/applications/editors/josm/dist/buildings_tools.jar
5554_Plugin-Url: 29435;​http://svn.openstreetmap.org/!svn/bc/29478/applications/editors/josm/dist/buildings_tools.jar
5548_Plugin-Url: 28888;​http://svn.openstreetmap.org/!svn/bc/28890/applications/editors/josm/dist/buildings_tools.jar
5464_Plugin-Url: 28807;​http://svn.openstreetmap.org/!svn/bc/28809/applications/editors/josm/dist/buildings_tools.jar
5035_Plugin-Url: 28529;​http://svn.openstreetmap.org/!svn/bc/28530/applications/editors/josm/dist/buildings_tools.jar
4980_Plugin-Url: 27865;​http://svn.openstreetmap.org/!svn/bc/27892/applications/editors/josm/dist/buildings_tools.jar
4855_Plugin-Url: 27676;​http://svn.openstreetmap.org/!svn/bc/27677/applications/editors/josm/dist/buildings_tools.jar
4667_Plugin-Url: 27562;​http://svn.openstreetmap.org/!svn/bc/27563/applications/editors/josm/dist/buildings_tools.jar
4549_Plugin-Url: 27355;​http://svn.openstreetmap.org/!svn/bc/27358/applications/editors/josm/dist/buildings_tools.jar
4395_Plugin-Url: 26731;​http://svn.openstreetmap.org/!svn/bc/26992/applications/editors/josm/dist/buildings_tools.jar
3922_Plugin-Url: 26530;​http://svn.openstreetmap.org/!svn/bc/26531/applications/editors/josm/dist/buildings_tools.jar
3835_Plugin-Url: 25192;​http://svn.openstreetmap.org/!svn/bc/25195/applications/editors/josm/dist/buildings_tools.jar
3518_Plugin-Url: 23804;​http://svn.openstreetmap.org/!svn/bc/24244/applications/editors/josm/dist/buildings_tools.jar

</snip>

My understanding is as JOSM v6210 is newer than the min version '6082_Plugin-Url', the plugin _should_ be updated to plugin v29778.

What actually happens is JOSM still shows 'buildings_tools: Version 29596 (local: 29596)'.

I reproduced this on another machine running 6210, but then tried 6115 and 5 updated plugins were detected.
This suggests there is a problem with the update system in 6210 that is not in 6115.

Looking more closely at 6210, after hitting 'Download list', almost all plug-ins show version 29854.
Repeating the same actions in 6115 gives some version errors (plugins too new for older JOSM - ignore but valid), but the plug-in versions are 'correct' and different.

See the attachment 'JOSM 6210 after Download list - see wrong Version.jpg'

[AlfonZ]

The ${JOSMversion}_Plugin-Url lines you've listed are for older versions of JOSM.
The more important are

Plugin-Mainversion: 6162
Plugin-Version: 29854

i.e. for JOSM version 6162 or newer use plugin version 29854.
JOSM versions 6161-6082 will use 29778.

If you have JOSM 6210, after downloading the list it should say the latest applicable plugin version is 29854.
You can try to delete cached list ${JOSMPreferenceFolder}/plugins/site-josm.openstreetmap.de-_plugin.txt and download it again, to check if it's correctly downloaded.