Modify

Opened 11 years ago

Closed 10 years ago

Last modified 6 years ago

#9046 closed defect (fixed)

'Paste Tags from buffer" in relation editor does nothing

Reported by: aceman Owned by: team
Priority: normal Milestone: 13.11
Component: Core Version: latest
Keywords: Cc: akks

Description

Copy tags (key+value) from an object.
Open some relation in the editor.
Click "Paste Tags from buffer".
Nothing happens.

But pressing Ctrl+V does paste the key=value from the buffer into the currently active field. But that is not exactly what is needed, it does not fill in the other field (either key or value).

Attachments (0)

Change History (14)

comment:1 by Don-vip, 11 years ago

Cc: akks added

comment:2 by mdk, 11 years ago

First I was a little bit confused, because it seems to work (latest 6214):

Copy an object from with CTRL-C, open a relation in the relation editor and click "Paste Tags from buffer" button - every thing works fine.
Also when I select an empty tag line and use CTRL-V, the ID of the object was inserted, not the key=value list.

But when I read the description again word by word, I found the solution: He only copies the key/value pairs:

  • select an object
  • go to the "Properties for selected objetcs" list
  • use the context menu "Copy all Keys/Values"

In this case you don't have a copy of the object, but a textual copy of the key/value pairs (space delimited) like "amenity=parking parking=surface".

But "Paste tags from buffer" only works with whole objects and not with only the key=value pairs. This is a little bit confusing, that copy/paste of the whole object pasts works with "Paste Tags from buffer", but copy/paste of "all Keys/Values" will fail.

Either we should point out, that "Copy all Keys/Values" cant be used inside JOSM to do anything useful (only for external paste) or "Paste tags from buffer" should handle both types (from object and from key=value string)

comment:3 by akks, 11 years ago

Yes, I forgot to reimplement text-pasting for relation editor (we need to paste tags into table, not into selected object).
Sorry, no time until weekend... If someone can add - feel free to commit.

comment:4 by mdk, 11 years ago

This may be the explanation for edits like:
http://www.openstreetmap.org/browse/way/223606681

... but most edits with a '=' in key or value are from other editors ;-)

in reply to:  2 ; comment:5 by aceman, 11 years ago

Replying to mdk:

But when I read the description again word by word, I found the solution: He only copies the key/value pairs:

  • select an object
  • go to the "Properties for selected objetcs" list
  • use the context menu "Copy all Keys/Values"

Yes, this is it, but I used "Copy Key/Value" (not all).

In this case you don't have a copy of the object, but a textual copy of the key/value pairs (space delimited) like >"amenity=parking parking=surface".

Yes. And then I use this to paste the tags on another object with Ctrl+Shift+V.

But "Paste tags from buffer" only works with whole objects and not with only the key=value pairs.

This is a little bit confusing, that copy/paste of the whole object pasts works with "Paste Tags from buffer", but >copy/paste of "all Keys/Values" will fail.

Yes, that is confusing, becase I thought "tags" are the "key=value" pairs. If that is not the case, what are "tags"?

Either we should point out, that "Copy all Keys/Values" cant be used inside JOSM to do anything useful (only for external >paste) or "Paste tags from buffer" should handle both types (from object and from key=value string)

I use "Copy Key/Value" and "Copy all Keys/Values" INSIDE JOSM regularly to copy tags from one object to another.

Now I wanted to apply the tags to a multipolygon (a relation) and that failed.

in reply to:  5 comment:6 by skyper, 11 years ago

Replying to aceman:

I use "Copy Key/Value" and "Copy all Keys/Values" INSIDE JOSM regularly to copy tags from one object to another.

Now I wanted to apply the tags to a multipolygon (a relation) and that failed.

It fails within the relation editor but it works with default selection. Just need to select the relation and paste.

comment:7 by aceman, 11 years ago

OK, but that is a bit dangerous as you do not see what tags there already are (in a regular object you see them). So the user would be reluctant to blindy paste the buffer.

in reply to:  7 ; comment:8 by skyper, 11 years ago

Replying to aceman:

OK, but that is a bit dangerous as you do not see what tags there already are (in a regular object you see them). So the user would be reluctant to blindy paste the buffer.

No, if a relation is selected its tags are listed in the property toggle dialog. No blind copy.

EDT: And of course there is "create multipolygon" which automatically moves all tags from way to relation. Sadly, relation membership is not supported atm.

Last edited 11 years ago by skyper (previous) (diff)

in reply to:  8 ; comment:9 by aceman, 11 years ago

Replying to skyper:

Replying to aceman:

OK, but that is a bit dangerous as you do not see what tags there already are (in a regular object you see them). So the user would be reluctant to blindy paste the buffer.

No, if a relation is selected its tags are listed in the property toggle dialog. No blind copy.

Yes, but how to select a relation? I do select an object and see it is in a relation, so I use the Edit button and then I am in the editor where the paste does not work. I'll see if there is a Select button in the relation list.

in reply to:  9 comment:10 by skyper, 11 years ago

Replying to aceman:

Yes, but how to select a relation? I do select an object and see it is in a relation, so I use the Edit button and then I am in the editor where the paste does not work. I'll see if there is a Select button in the relation list.

Either through relation list, middle mouse button cycle within map view or right click menu in properties toggle dialog. You should be able to select the relation or at least be able to select it in relation list almost everywhere though often you need to use right click menus.

comment:11 by akks, 10 years ago

Resolution: fixed
Status: newclosed

In 6319/josm:

fix #9046: Paste Tags in relation editor should work for text buffer

comment:12 by aceman, 10 years ago

Works like a charm, thanks a lot!

comment:13 by Don-vip, 10 years ago

Milestone: 13.11 (6383)

comment:14 by stoecker, 6 years ago

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.